Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Feature Request] Assertion operators #12484

Open
jasonyu1996 opened this issue Sep 8, 2018 · 6 comments
Open

[Feature Request] Assertion operators #12484

jasonyu1996 opened this issue Sep 8, 2018 · 6 comments

Comments

@jasonyu1996
Copy link
Contributor

jasonyu1996 commented Sep 8, 2018

Hi! I personally would be happy to see assertion operators in MXNet. While they might seem useless for imperative computations (the NDArray API), I believe they are absolutely helpful for symbolic computation (the Symbol API), especially when implementing libraries (e.g., implementing a library function that takes as input some symbols and returns the result after performing several symbols), where the validity of the input should be checked. Tensorflow has these https://tensorflow.google.cn/api_guides/python/check_ops . It should be noted that in order to ensure that these assertions are executed, how to add them to the computational graph in order to make the output dependent on these assertions should be considered.

@vrakesh
Copy link
Contributor

vrakesh commented Sep 8, 2018

@jasonyu1996 thank you for the feature request .

@mxnet-label-bot [Feature request]

@eric-haibin-lin
Copy link
Member

+1
@haojin2 @apeforest @samskalicky

@jasonyu1996
Copy link
Contributor Author

It seems that I am not the only person who thinks this type of operators beneficial. Is anyone interested in implementing this? @haojin2 @apeforest @samskalicky

@jasonyu1996
Copy link
Contributor Author

@eric-haibin-lin Hi! Do you think it is necessary to provide an interface for explicitly defining dependencies like this https://www.tensorflow.org/api_docs/python/tf/control_dependencies ?

@yemenr
Copy link

yemenr commented Nov 24, 2018

@jasonyu1996 Same question...

@jasonyu1996
Copy link
Contributor Author

It seems that this is indeed a feature in need. Could you please provide some instructions on how this should be implemented? @haojin2 @apeforest @samskalicky

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants