Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Deprecate USE_PROFILER from make/cmake. #11563

Closed
KellenSunderland opened this issue Jul 5, 2018 · 4 comments · Fixed by #15595
Closed

Deprecate USE_PROFILER from make/cmake. #11563

KellenSunderland opened this issue Jul 5, 2018 · 4 comments · Fixed by #15595
Labels
Build Deprecated Issues on Deprecated APIs/Features

Comments

@KellenSunderland
Copy link
Contributor

Let's deprecate USE_PROFILER from cmake and build systems as this flag is now always on at compile time. Having this option seems to be confusing users. Doing a full removal from cmake should be safe, and should present users with an intuitive message. For other build systems we may need to provide a deprecation message.

@rahul003
Copy link
Member

rahul003 commented Jul 5, 2018

Yes, it's not used for make as well. It can be safely removed. The only usage of USE_PROFILER in the repo are in build scripts and documentation currently.

@apeforest
Copy link
Contributor

apeforest commented Jul 9, 2018

@sandeep-krishnamurthy Please label this issue Build, Deprecated, Doc. Thx

@sandeep-krishnamurthy sandeep-krishnamurthy added Build Deprecated Issues on Deprecated APIs/Features labels Jul 10, 2018
@ChaiBapchya
Copy link
Contributor

@KellenSunderland any update on this? Can we close this issue otherwise?

@KellenSunderland
Copy link
Contributor Author

I think we still have to remove this option from our codebase right? I see a lot of documentation wrongly instructing users to set it to true for an example.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Build Deprecated Issues on Deprecated APIs/Features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants