Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Report clear errors when opencv::imdecode fails. #10389

Closed
piiswrong opened this issue Apr 3, 2018 · 3 comments · Fixed by #14433
Closed

Report clear errors when opencv::imdecode fails. #10389

piiswrong opened this issue Apr 3, 2018 · 3 comments · Fixed by #14433
Labels
Bug Exception Handling

Comments

@piiswrong
Copy link
Contributor

Currently when opencv function fails cryptic opencv error is raised. We should catch it and report which file failed.

see https://github.com/apache/incubator-mxnet/blob/121adb6660897d7cef223caba80a43412ab5c9e0/src/io/image_io.cc#L161
@piiswrong piiswrong added the Bug label Apr 3, 2018
@anirudh2290
Copy link
Member

Currently we don't catch exceptions unless they are dmlc::Error. This would need to change to catch other library exceptions. This TODO list needs to be prioritized: #9913

@lgov lgov mentioned this issue Nov 11, 2018
Closed
@vandanavk
Copy link
Contributor

@mxnet-label-bot add [Exception Handling]

@anirudh2290
Copy link
Member

Working on a PR for this

@anirudh2290 anirudh2290 mentioned this issue Mar 15, 2019
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Exception Handling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent crashes for opencv exception and std::exception anirudh2290/mxnet
4 participants
@piiswrong @anirudh2290 @vandanavk @marcoabreu