From b01106e0a1f344cf972651266073bfe2f1d920d9 Mon Sep 17 00:00:00 2001 From: Vandana Kannan Date: Fri, 14 Dec 2018 14:43:40 -0800 Subject: [PATCH] Address review comments --- tests/python-pytest/onnx/export/onnx_backend_test.py | 6 ++++-- tests/python-pytest/onnx/import/mxnet_backend_test.py | 5 ++++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/tests/python-pytest/onnx/export/onnx_backend_test.py b/tests/python-pytest/onnx/export/onnx_backend_test.py index bbf2a948e92c..2a843491762d 100644 --- a/tests/python-pytest/onnx/export/onnx_backend_test.py +++ b/tests/python-pytest/onnx/export/onnx_backend_test.py @@ -73,7 +73,6 @@ 'test_transpose', 'test_globalmaxpool', 'test_globalaveragepool', - # enabling partial test cases for matmul 'test_matmul', 'test_slice_cpu', 'test_slice_neg', @@ -144,8 +143,11 @@ for std_model_test in STANDARD_MODEL: BACKEND_TESTS.include(std_model_test) -BACKEND_TESTS.exclude('.*broadcast.*') BACKEND_TESTS.exclude('.*bcast.*') +# Excluding the following tests because expand and logSoftMax are +# not implemented in ONNX export. Enabling test_exp and test_log, +# will include the tests for these operators too, that can lead to +# 'Op not implemented' failures. BACKEND_TESTS.exclude('.*expand.*') BACKEND_TESTS.exclude('.*log_softmax.*') BACKEND_TESTS.exclude('.*logsoftmax.*') diff --git a/tests/python-pytest/onnx/import/mxnet_backend_test.py b/tests/python-pytest/onnx/import/mxnet_backend_test.py index 57aad9ac816b..df7349dac171 100644 --- a/tests/python-pytest/onnx/import/mxnet_backend_test.py +++ b/tests/python-pytest/onnx/import/mxnet_backend_test.py @@ -45,8 +45,11 @@ for std_model_test in test_cases.STANDARD_MODEL: BACKEND_TESTS.include(std_model_test) -BACKEND_TESTS.exclude('.*broadcast.*') BACKEND_TESTS.exclude('.*bcast.*') +# Excluding the following tests because expand is not implemented +# in ONNX import. Enabling test_exp will include the tests for +# this operator too, that can lead to 'Op not implemented' failures. +# logsoftmax tests are temporarily excluded. BACKEND_TESTS.exclude('.*logsoftmax.*') BACKEND_TESTS.exclude('.*expand.*')