Skip to content

Conversation

@slawekjaranowski
Copy link
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One comment though: the maven parent 45 disables spotless when running on JDK 25. That does not really change anything for this PR, but it would be nice if we could upgrade spotless there.

@slawekjaranowski
Copy link
Member Author

We should managed spotless in parent

@slawekjaranowski slawekjaranowski merged commit 1fc1972 into apache:master Sep 26, 2025
19 checks passed
@slawekjaranowski slawekjaranowski deleted the jdk-25 branch September 26, 2025 08:43
@github-actions github-actions bot added this to the 4.1.0 milestone Sep 26, 2025
cstamas pushed a commit to cstamas/maven that referenced this pull request Sep 26, 2025
* Build project by JDK 25

* Disable MavenIT0009GoalConfigurationTest on windows with JDK25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants