Re enable test on windows #11070
Closed
Re enable test on windows #11070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtnord
commented
Aug 28, 2025
| @DisabledOnOs( | ||
| value = WINDOWS, | ||
| disabledReason = "windows related issue https://github.com/apache/maven/pull/2312#issuecomment-2876291814") | ||
| void readFromUrlParsesPluginDescriptorCorrectly() throws Exception { |
Author
There was a problem hiding this comment.
the builder took (and still takes) an input stream not a URL. So this is renamed accordingly.
If it is expected that the test was using a Url then the test was already incorrectly implemented.
jtnord
commented
Aug 28, 2025
Comment on lines
+257
to
+259
| try (InputStream is = xmlFile.toUri().toURL().openStream()) { | ||
| PluginDescriptor descriptor = defaultPluginXmlFactory.read( | ||
| XmlReaderRequest.builder().inputStream(is).build()); |
Author
There was a problem hiding this comment.
the fix (everything else is whitespace)
Member
|
duplicate of #11069 ? |
Author
that and this is messed up as there is already a test that tests inputStreams. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a broken unit test on windows and re-enables it.
The naming of the test did not match what was actually tested, so updated that to reflect reality.
see #2312 (comment)
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.