Pull #2287: Modernize codebase with Java improvements - Unnecessary throws

Author: Vincent Potucek

compat/maven-artifact/src/test/java/org/apache/maven/artifact/ArtifactUtilsTest.java

@@ -63,7 +63,7 @@ void testToSnapshotVersion() {
      * Tests that the ordering of the map resembles the ordering of the input collection of artifacts.
      */
     @Test
-    void testArtifactMapByVersionlessIdOrdering() throws Exception {
+    void testArtifactMapByVersionlessIdOrdering() {
         List<Artifact> list = new ArrayList<>();
         list.add(newArtifact("b"));
         list.add(newArtifact("a"));

compat/maven-artifact/src/test/java/org/apache/maven/artifact/DefaultArtifactTest.java

@@ -55,7 +55,7 @@ class DefaultArtifactTest {
     private ArtifactHandlerMock artifactHandler;
 
     @BeforeEach
-    void setUp() throws Exception {
+    void setUp() {
         artifactHandler = new ArtifactHandlerMock();
         versionRange = VersionRange.createFromVersion(version);
         artifact = new DefaultArtifact(groupId, artifactId, versionRange, scope, type, classifier, artifactHandler);

compat/maven-compat/src/main/java/org/apache/maven/DefaultProjectDependenciesResolver.java

@@ -107,7 +107,7 @@ private Set<Artifact> resolveImpl(
             Collection<String> scopesToResolve,
             MavenSession session,
             Set<String> projectIds)
-            throws ArtifactResolutionException, ArtifactNotFoundException {
+            throws ArtifactResolutionException {
         Set<Artifact> resolved = new LinkedHashSet<>();
 
         if (projects == null || projects.isEmpty()) {

compat/maven-compat/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactResolver.java

@@ -349,7 +349,7 @@ public ArtifactResolutionResult resolveTransitively(
     }
 
     public ArtifactResolutionResult resolveWithExceptions(ArtifactResolutionRequest request)
-            throws ArtifactResolutionException, ArtifactNotFoundException {
+            throws ArtifactResolutionException {
         ArtifactResolutionResult result = resolve(request);
 
         // We have collected all the problems so let's mimic the way the old code worked and just blow up right here.

compat/maven-compat/src/main/java/org/apache/maven/repository/metadata/ClasspathContainer.java

@@ -68,7 +68,7 @@ public List<ArtifactMetadata> getClasspath() {
     }
 
     // -------------------------------------------------------------------------------------------
-    public MetadataTreeNode getClasspathAsTree() throws MetadataResolutionException {
+    public MetadataTreeNode getClasspathAsTree() {
         if (classpath == null || classpath.size() < 1) {
             return null;
         }

compat/maven-compat/src/main/java/org/apache/maven/settings/DefaultMavenSettingsBuilder.java

@@ -75,7 +75,7 @@ public Settings buildSettings(File userSettingsFile, boolean useCachedSettings)
         return buildSettings(userSettingsFile);
     }
 
-    private Settings build(SettingsBuildingRequest request) throws IOException, XmlPullParserException {
+    private Settings build(SettingsBuildingRequest request) throws IOException {
         try {
             return settingsBuilder.build(request).getEffectiveSettings();
         } catch (SettingsBuildingException e) {

compat/maven-compat/src/test/java/org/apache/maven/artifact/AbstractArtifactComponentTestCase.java

@@ -142,7 +142,7 @@ protected String getRepositoryLayout() {
         return "default";
     }
 
-    protected ArtifactRepository localRepository() throws Exception {
+    protected ArtifactRepository localRepository() {
         String path = "target/test-repositories/" + component() + "/local-repository";
 
         File f = new File(getBasedir(), path);
@@ -151,7 +151,7 @@ protected ArtifactRepository localRepository() throws Exception {
                 "local", "file://" + f.getPath(), repoLayout, null, null);
     }
 
-    protected ArtifactRepository remoteRepository() throws Exception {
+    protected ArtifactRepository remoteRepository() {
         String path = "target/test-repositories/" + component() + "/remote-repository";
 
         File f = new File(getBasedir(), path);
@@ -164,7 +164,7 @@ protected ArtifactRepository remoteRepository() throws Exception {
                 new ArtifactRepositoryPolicy());
     }
 
-    protected ArtifactRepository badRemoteRepository() throws Exception {
+    protected ArtifactRepository badRemoteRepository() {
         return artifactRepositoryFactory.createArtifactRepository(
                 "test", "http://foo.bar/repository", repoLayout, null, null);
     }
@@ -281,7 +281,7 @@ protected Artifact createArtifact(String artifactId, String version, String type
         return createArtifact("org.apache.maven", artifactId, version, type);
     }
 
-    protected Artifact createArtifact(String groupId, String artifactId, String version, String type) throws Exception {
+    protected Artifact createArtifact(String groupId, String artifactId, String version, String type) {
         Artifact a = artifactFactory.createBuildArtifact(groupId, artifactId, version, type);
 
         return a;

compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/ArtifactResolverTest.java

@@ -97,7 +97,7 @@ void testResolutionOfASingleArtifactWhereTheArtifactIsNotPresentLocallyAndMustBe
     }
 
     @Override
-    protected Artifact createArtifact(String groupId, String artifactId, String version, String type) throws Exception {
+    protected Artifact createArtifact(String groupId, String artifactId, String version, String type) {
         // for the anonymous classes
         return super.createArtifact(groupId, artifactId, version, type);
     }

compat/maven-compat/src/test/java/org/apache/maven/repository/LegacyRepositorySystemTest.java

@@ -56,7 +56,6 @@
 import org.apache.maven.project.artifact.DefaultMetadataSource;
 import org.apache.maven.repository.legacy.LegacyRepositorySystem;
 import org.codehaus.plexus.PlexusContainer;
-import org.codehaus.plexus.component.composition.CycleDetectedInComponentGraphException;
 import org.codehaus.plexus.testing.PlexusTest;
 import org.eclipse.aether.DefaultRepositorySystemSession;
 import org.eclipse.aether.internal.impl.DefaultChecksumPolicyProvider;
@@ -253,7 +252,7 @@ void testLocalRepositoryBasedir() throws Exception {
     SwitchableMetadataSource switchableMetadataSource;
 
     @BeforeEach
-    void setup() throws CycleDetectedInComponentGraphException {
+    void setup() {
         switchableMetadataSource.setDelegate(defaultMetadataSource);
     }
 }

compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/DefaultWagonManagerTest.java

@@ -105,7 +105,7 @@ public void transferInitiated(TransferEvent transferEvent) {
     }
 
     @Test
-    void testGetMissingJar() throws TransferFailedException, UnsupportedProtocolException, IOException {
+    void testGetMissingJar() throws TransferFailedException, IOException {
         Artifact artifact = createTestArtifact("target/test-data/get-missing-jar", "jar");
 
         ArtifactRepository repo = createStringRepo();
@@ -116,7 +116,7 @@ void testGetMissingJar() throws TransferFailedException, UnsupportedProtocolExce
     }
 
     @Test
-    void testGetMissingJarForced() throws TransferFailedException, UnsupportedProtocolException, IOException {
+    void testGetMissingJarForced() throws TransferFailedException, IOException {
         Artifact artifact = createTestArtifact("target/test-data/get-missing-jar", "jar");
 
         ArtifactRepository repo = createStringRepo();