[MSHADE-419] Add an integration test #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om when shadedArtifactAttached The problem was introduced by MSHADE-321 in 3.3.0 because before, the `createDependencyReducedPom` method was only ever called when `shadedArtifactAttached` is false. The `createDependencyReducedPom` method not only writes the dependency reduced pom file but also modifies the current project to use it as replacement for its original pom. This has an effect on all maven build logic being executed afterwards. Thus, in multi module builds, when a module attaches a shaded jar, its non-shaded artifact no longer contains transitive dependencies when used from other modules, even though the pom in its jar still declares them. # Conflicts: # src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java
8 tasks
gnodet
changed the title
elharo
reviewed
Mar 19, 2023
| } | ||
|
|
||
| JarFile jarFile = null | ||
| try |
There was a problem hiding this comment.
I think you can use try with resources here
| String jarPomPath = "META-INF/maven/org.apache.maven.its.shade.cdrp-mm/mshade-419-impl/pom.xml" | ||
| String apiDependencyString = "<artifactId>mshade-419-api</artifactId>" | ||
|
|
||
| String mainPomFileContent = FileUtils.fileRead( new File( basedir, "impl/pom.xml" ), "UTF-8" ) |
There was a problem hiding this comment.
can we use the Apache Commons IO version instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: https://issues.apache.org/jira/browse/MSHADE-419
Shade plugin causes pom to be created without compile dependencies
IT extracted from #149
===============
The problem was introduced by MSHADE-321 in 3.3.0 because before, the
createDependencyReducedPommethod was only ever called whenshadedArtifactAttachedis false.The
createDependencyReducedPommethod not only writes the dependency reduced pom file but also modifies the current project to use it as replacement for its original pom.This has an effect on all maven build logic being executed afterwards.
Thus, in multi module builds, when a module attaches a shaded jar, its non-shaded artifact no longer contains transitive dependencies when used from other modules, even though the pom in its jar still declares them.