Skip to content

Commit ecbd5db

Browse files
desruisseauxslachiewicz
authored andcommitted
Remove an unused dependency, add missing @Override annotations, avoid an usage of / path separator.
1 parent b99c9db commit ecbd5db

File tree

5 files changed

+7
-12
lines changed

5 files changed

+7
-12
lines changed

pom.xml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -79,16 +79,6 @@ under the License.
7979
<maven.site.path>${maven4x.site.path}</maven.site.path>
8080
</properties>
8181

82-
<dependencyManagement>
83-
<dependencies>
84-
<dependency>
85-
<groupId>com.google.guava</groupId>
86-
<artifactId>guava</artifactId>
87-
<version>${guavaVersion}</version>
88-
</dependency>
89-
</dependencies>
90-
</dependencyManagement>
91-
9282
<dependencies>
9383
<dependency>
9484
<groupId>org.apache.maven</groupId>

src/main/java/org/apache/maven/plugins/clean/CleanMojo.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
import java.io.IOException;
2222
import java.nio.file.Path;
23-
import java.nio.file.Paths;
2423

2524
import org.apache.maven.api.Session;
2625
import org.apache.maven.api.di.Inject;
@@ -220,6 +219,7 @@ public class CleanMojo implements org.apache.maven.api.plugin.Mojo {
220219
* @throws MojoException When a directory failed to get deleted.
221220
* @see org.apache.maven.api.plugin.Mojo#execute()
222221
*/
222+
@Override
223223
public void execute() {
224224
if (skip) {
225225
getLog().info("Clean is skipped.");
@@ -232,7 +232,7 @@ public void execute() {
232232
if (fast && this.fastDir != null) {
233233
fastDir = this.fastDir;
234234
} else if (fast && multiModuleProjectDirectory != null) {
235-
fastDir = Paths.get(multiModuleProjectDirectory, "target/.clean");
235+
fastDir = Path.of(multiModuleProjectDirectory, "target", ".clean");
236236
} else {
237237
fastDir = null;
238238
if (fast) {

src/main/java/org/apache/maven/plugins/clean/Cleaner.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -407,6 +407,7 @@ private BackgroundCleaner(Cleaner cleaner, Path dir, String fastMode) {
407407
init(cleaner.fastDir, dir);
408408
}
409409

410+
@Override
410411
public void run() {
411412
while (true) {
412413
Path basedir = pollNext();

src/main/java/org/apache/maven/plugins/clean/Fileset.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ public boolean isUseDefaultExcludes() {
8787
* <I>[included files]</I>, excluded: <I>[excluded files]</I>)"</code>
8888
* @see java.lang.Object#toString()
8989
*/
90+
@Override
9091
public String toString() {
9192
return "file set: " + getDirectory() + " (included: " + Arrays.asList(getIncludes()) + ", excluded: "
9293
+ Arrays.asList(getExcludes()) + ")";

src/main/java/org/apache/maven/plugins/clean/GlobSelector.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ private static String normalizePattern(String pattern) {
9090
return normalized;
9191
}
9292

93+
@Override
9394
public boolean isSelected(String pathname) {
9495
return (includes.length <= 0 || isMatched(pathname, includes))
9596
&& (excludes.length <= 0 || !isMatched(pathname, excludes));
@@ -104,6 +105,7 @@ private static boolean isMatched(String pathname, String[] patterns) {
104105
return false;
105106
}
106107

108+
@Override
107109
public boolean couldHoldSelected(String pathname) {
108110
for (String include : includes) {
109111
if (SelectorUtils.matchPatternStart(include, pathname)) {
@@ -113,6 +115,7 @@ public boolean couldHoldSelected(String pathname) {
113115
return includes.length <= 0;
114116
}
115117

118+
@Override
116119
public String toString() {
117120
return str;
118121
}

0 commit comments

Comments
 (0)