From 26d1faf477493380f93836134379ce78d0d45a91 Mon Sep 17 00:00:00 2001
From: jackwener <jakevingoo@gmail.com>
Date: Sat, 11 Jul 2026 23:56:00 +0800
Subject: [PATCH] =?UTF-8?q?fix(desktop):=20fresh=20sweep=20on=20new=20tip?=
 =?UTF-8?q?=20=E2=80=94=20restraint=20consistency,=20bot=20primary,=20hone?=
 =?UTF-8?q?st=20fade=20(round=2016)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Post-pull discovery sweep over the externally-merged tip (LiteLLM,
Goal #625, FormatJson, tool-row rework — all reviewed clean, incl. the
Goal kill-switch pill which correctly absorbed the earlier review
blockers). Three finds, fixed:

- 每日回顾 已生成 chip still success-green — the EXPECTED outcome per
  the #651 restraint rule (健康 正常 and 权限 已授权 are already
  neutral); failures keep destructive.
- 机器人对话 had NO primary at all — 测试并连接 (the form's completion
  action) promoted from secondary to default.
- first-run provider list: the 28px bottom fade left a half-clipped row
  still half-legible — read as broken clipping; 56px fully veils it.

Also re-learned: the desktop test suite does not compile renderer pages
(a JSX syntax error sailed through 2309 green tests and only vite/
typecheck caught it) — full typecheck now part of this round's gate.
Desktop 2309/2309 + typecheck + dead-css clean; CDP captures verified.
---
 apps/desktop/src/renderer/settings/bot-chat-settings-page.tsx | 3 ++-
 apps/desktop/src/renderer/styles/onboarding.css               | 4 +++-
 packages/ui/src/daily-review-panel.tsx                        | 4 +++-
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/apps/desktop/src/renderer/settings/bot-chat-settings-page.tsx b/apps/desktop/src/renderer/settings/bot-chat-settings-page.tsx
index 6f3143be76..89af28b5a4 100644
--- a/apps/desktop/src/renderer/settings/bot-chat-settings-page.tsx
+++ b/apps/desktop/src/renderer/settings/bot-chat-settings-page.tsx
@@ -780,8 +780,9 @@ export function BotChatSettingsPage(props: {
             </>
           ) : support === 'runtime' && !selectedStatus?.running ? (
             <Button
+              // One primary per view: 测试并连接 is the form's completion
+              // action — the page previously had no primary at all.
               type="button"
-              variant="secondary"
               disabled={botActionBusy}
               onClick={testAndConnect}
             >
diff --git a/apps/desktop/src/renderer/styles/onboarding.css b/apps/desktop/src/renderer/styles/onboarding.css
index 6084e1b489..6cce86623b 100644
--- a/apps/desktop/src/renderer/styles/onboarding.css
+++ b/apps/desktop/src/renderer/styles/onboarding.css
@@ -229,7 +229,9 @@
   left: var(--border-width-hairline);
   right: var(--border-width-hairline);
   bottom: var(--border-width-hairline);
-  height: 28px;
+  /* 56px: tall enough to fully veil a half-clipped row's text — at 28px the
+     cut row stayed half-legible under the fade and still read as broken. */
+  height: 56px;
   border-radius: 0 0 var(--radius-surface) var(--radius-surface);
   background: linear-gradient(to bottom, oklch(from var(--background-elevated) l c h / 0), var(--background-elevated));
   pointer-events: none;
diff --git a/packages/ui/src/daily-review-panel.tsx b/packages/ui/src/daily-review-panel.tsx
index 8fd920ac91..6c10077453 100644
--- a/packages/ui/src/daily-review-panel.tsx
+++ b/packages/ui/src/daily-review-panel.tsx
@@ -57,7 +57,9 @@ const EMPTY_MODEL_OPTIONS: ReadonlyArray<readonly [string, string]> = [];
 // no_model = the run could not produce a report (destructive). no_data /
 // skipped are expected non-events and stay neutral (exception-only color).
 function dailyReviewArchiveChipTone(status: DailyReviewArchive['status']): ChipProps['variant'] {
-  if (status === 'ok') return 'success';
+  // Status-color restraint (#651 rule): 已生成 is the EXPECTED outcome —
+  // neutral ink, matching 健康 正常 and 权限 已授权. Color stays reserved
+  // for the failures that need attention.
   if (status === 'failed' || status === 'no_model') return 'destructive';
   return 'neutral';
 }