diff --git a/.github/workflows/style.yml b/.github/workflows/style.yml index 6c469b9c225..e86da80958b 100644 --- a/.github/workflows/style.yml +++ b/.github/workflows/style.yml @@ -28,7 +28,7 @@ on: jobs: linter: - name: Style and Dep check + name: Style and Dependency check runs-on: ubuntu-20.04 strategy: matrix: @@ -41,8 +41,6 @@ jobs: with: distribution: zulu java-version: 8 - - name: Server dependency check - run: build/dependency.sh - name: Scalastyle with Maven run: build/mvn scalastyle:check ${{ matrix.profiles }} - name: Upload scalastyle report @@ -50,3 +48,10 @@ jobs: run: for log in `find * -name "scalastyle-output.xml"`; do echo "=========$log========="; grep "error" $log; done - name: JavaStyle with Maven run: build/mvn spotless:check ${{ matrix.profiles }} + - name: Check dependency list + run: >- + build/mvn clean install -V -Pflink-provided,spark-provided -Dorg.slf4j.simpleLogger.defaultLogLevel=warn \ + -Dmaven.javadoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -DskipTests \ + -Pflink-provided,spark-provided \ + -pl kyuubi-ctl,kyuubi-server,kyuubi-assembly -am + build/dependency.sh diff --git a/build/dependency.sh b/build/dependency.sh index f9e702e5397..69d946f39aa 100755 --- a/build/dependency.sh +++ b/build/dependency.sh @@ -24,15 +24,15 @@ export LC_ALL=C PWD=$(cd "$(dirname "$0")"/.. || exit; pwd) -MVN="${PWD}"/build/mvn +MVN="${PWD}/build/mvn" -DEP_PR="${PWD}"/dev/dependencyList.tmp -DEP="${PWD}"/dev/dependencyList +DEP_PR="${PWD}/dev/dependencyList.tmp" +DEP="${PWD}/dev/dependencyList" function build_classpath() { - $MVN dependency:build-classpath -pl :kyuubi-ctl_2.12,:kyuubi-server_2.12,:kyuubi-assembly_2.12 |\ + $MVN dependency:build-classpath -pl kyuubi-ctl,kyuubi-server,kyuubi-assembly |\ grep -v "INFO\|WARN" | \ tail -1 | \ tr ":" "\n" | \ @@ -49,12 +49,12 @@ function build_classpath() { function check_diff() { set +e - the_diff=$(diff ${DEP} ${DEP_PR}) + the_diff=$(diff "${DEP}" "${DEP_PR}") set -e rm -rf "${DEP_PR}" - if [[ -n $the_diff ]]; then + if [[ -n "${the_diff}" ]]; then echo "Dependency List Changed Detected: " - echo ${the_diff} + echo "${the_diff}" echo "To update the dependency file, run './build/dependency.sh --replace'." exit 1 fi diff --git a/dev/dependencyList b/dev/dependencyList index 14c5b3c881e..5c4ebd64ebd 100644 --- a/dev/dependencyList +++ b/dev/dependencyList @@ -94,7 +94,6 @@ simpleclient_tracer_common/0.14.1//simpleclient_tracer_common-0.14.1.jar simpleclient_tracer_otel/0.14.1//simpleclient_tracer_otel-0.14.1.jar simpleclient_tracer_otel_agent/0.14.1//simpleclient_tracer_otel_agent-0.14.1.jar slf4j-api/1.7.30//slf4j-api-1.7.30.jar -slf4j-log4j12/1.7.30//slf4j-log4j12-1.7.30.jar snakeyaml/1.27//snakeyaml-1.27.jar swagger-annotations/2.1.11//swagger-annotations-2.1.11.jar swagger-core/2.1.11//swagger-core-2.1.11.jar diff --git a/dev/kyuubi-extension-spark-3-2/pom.xml b/dev/kyuubi-extension-spark-3-2/pom.xml index bdc2820f92e..37bac841dbf 100644 --- a/dev/kyuubi-extension-spark-3-2/pom.xml +++ b/dev/kyuubi-extension-spark-3-2/pom.xml @@ -98,12 +98,6 @@ test - - org.scalatest - scalatest_${scala.binary.version} - test - - org.apache.hadoop hadoop-client-runtime diff --git a/dev/kyuubi-extension-spark-common/pom.xml b/dev/kyuubi-extension-spark-common/pom.xml index 8d1362ce55b..6c124915a5c 100644 --- a/dev/kyuubi-extension-spark-common/pom.xml +++ b/dev/kyuubi-extension-spark-common/pom.xml @@ -84,12 +84,6 @@ test - - org.scalatest - scalatest_${scala.binary.version} - test - - org.apache.hadoop hadoop-client-runtime diff --git a/pom.xml b/pom.xml index 4ac26b60687..d654dd94ef2 100644 --- a/pom.xml +++ b/pom.xml @@ -347,9 +347,23 @@ spark-repl_${scala.binary.version} ${spark.version} + - * - * + org.apache.hadoop + hadoop-client + + + + log4j + log4j + + + org.slf4j + slf4j-log4j12 @@ -366,6 +380,9 @@ org.apache.hadoop hadoop-client + log4j log4j @@ -393,6 +410,17 @@ org.apache.hadoop hadoop-common + + + log4j + log4j + + + org.slf4j + slf4j-log4j12 + @@ -409,6 +437,10 @@ org.apache.hadoop hadoop-client + @@ -425,16 +457,13 @@ org.apache.hadoop hadoop-client + - - org.scalatestplus - scalacheck-1-15_${scala.binary.version} - ${scalacheck.version} - test - - org.apache.spark spark-sql_${scala.binary.version} @@ -448,6 +477,10 @@ org.apache.hadoop hadoop-client + @@ -568,18 +601,6 @@ ${slf4j.version} - - org.slf4j - slf4j-log4j12 - ${slf4j.version} - - - log4j - log4j - - - - org.slf4j jcl-over-slf4j @@ -775,6 +796,13 @@ ${scalatest.version} + + org.scalatestplus + scalacheck-1-15_${scala.binary.version} + ${scalacheck.version} + test + + org.apache.hadoop hadoop-minikdc