clang: error: unsupported option '-static-libgcc' on MacOS

[mapleFU]

Search before asking

• I had searched in the issues and found no similar issues.

Motivation

On MacOS clang-13, it doesn't support -static-libgcc. So the code below might get:

clang: error: unsupported option '-static-libgcc'

Is this expected?

Solution

if ((CMAKE_CXX_COMPILER_ID STREQUAL "GNU") OR (CMAKE_CXX_COMPILER_ID STREQUAL "Clang"))
-    set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -static-libgcc")
+    if (NOT APPLE)
+       set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -static-libgcc")
+    endif()

    if(ENABLE_STATIC_LIBSTDCXX)
        try_compile(FOUND_STATIC_LIBSTDCXX ${PROJECT_BINARY_DIR} ${PROJECT_SOURCE_DIR}/cmake/checks/static_libstdcxx.cc
            LINK_OPTIONS -static-libstdc++ CXX_STANDARD 11)

        if(NOT FOUND_STATIC_LIBSTDCXX)
            message(FATAL_ERROR "cannot find static library of libstdc++, please add ENABLE_STATIC_LIBSTDCXX=OFF to disable")
        endif()

        set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -static-libstdc++")
    endif()
endif()

Are you willing to submit a PR?

• I'm willing to submit a PR!

[PragmaTwice]

Looks good to me.

[enjoy-binbin]

It was fixed in #1555

[mapleFU]

Too tired today that I forgot to close it, thanks!