From 2bf4a7673354a4efaa367a240f4c987e3dbce6d9 Mon Sep 17 00:00:00 2001 From: Geordie Date: Mon, 11 Jan 2021 01:04:07 +0800 Subject: [PATCH 1/2] MINOR: Remove assertDoesNotThrow at last line --- .../apache/kafka/log4jappender/KafkaLog4jAppenderTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java b/log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java index f0953e6c6649e..0856110159dab 100644 --- a/log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java +++ b/log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java @@ -140,7 +140,7 @@ public void testSyncSendWithoutIgnoringExceptionsShouldNotThrowException() { MockKafkaLog4jAppender mockKafkaLog4jAppender = getMockKafkaLog4jAppender(); replaceProducerWithMocked(mockKafkaLog4jAppender, true); - assertDoesNotThrow(() -> logger.error(getMessage(0))); + logger.error(getMessage(0)); } @Test @@ -148,7 +148,7 @@ public void testRealProducerConfigWithSyncSendShouldNotThrowException() { Properties props = getLog4jConfigWithRealProducer(true); PropertyConfigurator.configure(props); - assertDoesNotThrow(() -> logger.error(getMessage(0))); + logger.error(getMessage(0)); } @Test From 8df0704bfc24a5b8d3717a7f03e9bd439a74576e Mon Sep 17 00:00:00 2001 From: geordie Date: Mon, 11 Jan 2021 10:41:00 +0800 Subject: [PATCH 2/2] remove unused import --- .../org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java | 1 - 1 file changed, 1 deletion(-) diff --git a/log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java b/log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java index 0856110159dab..9711d29f31579 100644 --- a/log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java +++ b/log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java @@ -36,7 +36,6 @@ import java.util.concurrent.Future; import java.util.concurrent.TimeoutException; -import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertThrows;