From 87382404ee201df84f19048cd561e43c9146bdfc Mon Sep 17 00:00:00 2001 From: APaMio Date: Sun, 6 Dec 2020 23:55:16 +0800 Subject: [PATCH] HINOR-Using primitive data types for loop index Change the loop index from Object into primitive data type --- .../clients/producer/internals/StickyPartitionCache.java | 2 +- .../org/apache/kafka/connect/tools/SchemaSourceConnector.java | 4 ++-- .../apache/kafka/connect/tools/VerifiableSinkConnector.java | 4 ++-- .../apache/kafka/connect/tools/VerifiableSourceConnector.java | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/clients/src/main/java/org/apache/kafka/clients/producer/internals/StickyPartitionCache.java b/clients/src/main/java/org/apache/kafka/clients/producer/internals/StickyPartitionCache.java index bfe1ac6c6fc3d..b432009261b34 100644 --- a/clients/src/main/java/org/apache/kafka/clients/producer/internals/StickyPartitionCache.java +++ b/clients/src/main/java/org/apache/kafka/clients/producer/internals/StickyPartitionCache.java @@ -58,7 +58,7 @@ public int nextPartition(String topic, Cluster cluster, int prevPartition) { newPart = availablePartitions.get(0).partition(); } else { while (newPart == null || newPart.equals(oldPart)) { - Integer random = Utils.toPositive(ThreadLocalRandom.current().nextInt()); + int random = Utils.toPositive(ThreadLocalRandom.current().nextInt()); newPart = availablePartitions.get(random % availablePartitions.size()).partition(); } } diff --git a/connect/runtime/src/main/java/org/apache/kafka/connect/tools/SchemaSourceConnector.java b/connect/runtime/src/main/java/org/apache/kafka/connect/tools/SchemaSourceConnector.java index eeee0f6ca8d32..06379d5f2811c 100644 --- a/connect/runtime/src/main/java/org/apache/kafka/connect/tools/SchemaSourceConnector.java +++ b/connect/runtime/src/main/java/org/apache/kafka/connect/tools/SchemaSourceConnector.java @@ -48,9 +48,9 @@ public Class taskClass() { @Override public List> taskConfigs(int maxTasks) { ArrayList> configs = new ArrayList<>(); - for (Integer i = 0; i < maxTasks; i++) { + for (int i = 0; i < maxTasks; i++) { Map props = new HashMap<>(config); - props.put(SchemaSourceTask.ID_CONFIG, i.toString()); + props.put(SchemaSourceTask.ID_CONFIG, String.valueOf(i)); configs.add(props); } return configs; diff --git a/connect/runtime/src/main/java/org/apache/kafka/connect/tools/VerifiableSinkConnector.java b/connect/runtime/src/main/java/org/apache/kafka/connect/tools/VerifiableSinkConnector.java index 12bcb353cd875..55f95a3448c67 100644 --- a/connect/runtime/src/main/java/org/apache/kafka/connect/tools/VerifiableSinkConnector.java +++ b/connect/runtime/src/main/java/org/apache/kafka/connect/tools/VerifiableSinkConnector.java @@ -50,9 +50,9 @@ public Class taskClass() { @Override public List> taskConfigs(int maxTasks) { ArrayList> configs = new ArrayList<>(); - for (Integer i = 0; i < maxTasks; i++) { + for (int i = 0; i < maxTasks; i++) { Map props = new HashMap<>(config); - props.put(VerifiableSinkTask.ID_CONFIG, i.toString()); + props.put(VerifiableSinkTask.ID_CONFIG, String.valueOf(i)); configs.add(props); } return configs; diff --git a/connect/runtime/src/main/java/org/apache/kafka/connect/tools/VerifiableSourceConnector.java b/connect/runtime/src/main/java/org/apache/kafka/connect/tools/VerifiableSourceConnector.java index cd7e3105457cc..6262cc3b0bb1e 100644 --- a/connect/runtime/src/main/java/org/apache/kafka/connect/tools/VerifiableSourceConnector.java +++ b/connect/runtime/src/main/java/org/apache/kafka/connect/tools/VerifiableSourceConnector.java @@ -50,9 +50,9 @@ public Class taskClass() { @Override public List> taskConfigs(int maxTasks) { ArrayList> configs = new ArrayList<>(); - for (Integer i = 0; i < maxTasks; i++) { + for (int i = 0; i < maxTasks; i++) { Map props = new HashMap<>(config); - props.put(VerifiableSourceTask.ID_CONFIG, i.toString()); + props.put(VerifiableSourceTask.ID_CONFIG, String.valueOf(i)); configs.add(props); } return configs;