From f8887d3e2c335841a7c8a9533bedbee0b8d28db6 Mon Sep 17 00:00:00 2001 From: Guozhang Wang Date: Tue, 1 Dec 2020 10:48:11 -0800 Subject: [PATCH 1/2] do not print log4j for memberId required --- .../clients/consumer/internals/AbstractCoordinator.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java index af6e262078d7a..10dbb8181e89a 100644 --- a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java +++ b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java @@ -465,7 +465,11 @@ boolean joinGroupIfNeeded(final Timer timer) { } } else { final RuntimeException exception = future.exception(); - log.info("Rebalance failed.", exception); + + if (!(exception instanceof MemberIdRequiredException)) { + log.info("Rebalance failed.", exception); + } + resetJoinGroupFuture(); if (exception instanceof UnknownMemberIdException || exception instanceof RebalanceInProgressException || From 51dcab57ea74a07df1b6cd7937e2fb2bbf0c1380 Mon Sep 17 00:00:00 2001 From: Guozhang Wang Date: Fri, 4 Dec 2020 10:07:50 -0800 Subject: [PATCH 2/2] github comments --- .../kafka/clients/consumer/internals/AbstractCoordinator.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java index 10dbb8181e89a..4ca71bb626a06 100644 --- a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java +++ b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java @@ -466,6 +466,8 @@ boolean joinGroupIfNeeded(final Timer timer) { } else { final RuntimeException exception = future.exception(); + // we do not need to log error for memberId required, + // since it is not really an error and is transient if (!(exception instanceof MemberIdRequiredException)) { log.info("Rebalance failed.", exception); }