From 61a4b4fb0da027155d0ca87b35b86995be6a7de4 Mon Sep 17 00:00:00 2001 From: Jason Gustafson Date: Thu, 16 Jul 2020 19:32:53 -0700 Subject: [PATCH 1/2] MINOR: Fix flaky system test assertion after static member fencing --- tests/kafkatest/tests/client/consumer_test.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/kafkatest/tests/client/consumer_test.py b/tests/kafkatest/tests/client/consumer_test.py index 131123f55ff3c..982be24dc81f5 100644 --- a/tests/kafkatest/tests/client/consumer_test.py +++ b/tests/kafkatest/tests/client/consumer_test.py @@ -254,7 +254,9 @@ def test_fencing_static_consumer(self, num_conflict_consumers, fencing_stage): self.await_members(conflict_consumer, num_conflict_consumers) self.await_members(consumer, len(consumer.nodes) - num_conflict_consumers) - assert len(consumer.dead_nodes()) == num_conflict_consumers + wait_until(lambda: len(consumer.dead_nodes()) == num_conflict_consumers, + timeout_sec=10, + err_msg("Timed out waiting for the fenced consumers to stop")) else: consumer.start() conflict_consumer.start() From b2cb7402ada72cc188cbe209e3a5b1aa5daf5207 Mon Sep 17 00:00:00 2001 From: Jason Gustafson Date: Fri, 17 Jul 2020 10:02:06 -0700 Subject: [PATCH 2/2] Fix syntax error --- tests/kafkatest/tests/client/consumer_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kafkatest/tests/client/consumer_test.py b/tests/kafkatest/tests/client/consumer_test.py index 982be24dc81f5..731a24de915dd 100644 --- a/tests/kafkatest/tests/client/consumer_test.py +++ b/tests/kafkatest/tests/client/consumer_test.py @@ -256,7 +256,7 @@ def test_fencing_static_consumer(self, num_conflict_consumers, fencing_stage): wait_until(lambda: len(consumer.dead_nodes()) == num_conflict_consumers, timeout_sec=10, - err_msg("Timed out waiting for the fenced consumers to stop")) + err_msg="Timed out waiting for the fenced consumers to stop") else: consumer.start() conflict_consumer.start()