From 8a17e53b9336f2573355478f4e7422810de231fd Mon Sep 17 00:00:00 2001 From: "Matthias J. Sax" Date: Thu, 12 Sep 2019 14:06:39 -0700 Subject: [PATCH 1/2] HOTFIX: fix compile error in 2.0 branch --- .../streams/processor/internals/RecordCollectorTest.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java b/streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java index 82ffb87dfa92a..ef883c4f4bdfd 100644 --- a/streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java @@ -50,10 +50,9 @@ import java.util.Map; import java.util.concurrent.Future; +import static org.hamcrest.CoreMatchers.equalTo; import static org.hamcrest.MatcherAssert.assertThat; -import static org.hamcrest.Matchers.equalTo; import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertThrows; import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; @@ -171,7 +170,10 @@ public void shouldNotAllowOffsetsToBeUpdatedExternally() { final Map offsets = collector.offsets(); assertThat(offsets.get(topicPartition), equalTo(2L)); - assertThrows(UnsupportedOperationException.class, () -> offsets.put(new TopicPartition(topic, 0), 50L)); + try { + offsets.put(new TopicPartition(topic, 0), 50L); + fail("Should have thrown UnsupportedOperationException"); + } catch (final UnsupportedOperationException expected) {} assertThat(collector.offsets().get(topicPartition), equalTo(2L)); } From 6adae343d4346fc446efae08fdbd1c107ee14f52 Mon Sep 17 00:00:00 2001 From: "Matthias J. Sax" Date: Thu, 12 Sep 2019 14:36:38 -0700 Subject: [PATCH 2/2] fix checkstyle --- .../kafka/streams/processor/internals/RecordCollectorTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java b/streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java index ef883c4f4bdfd..92b94741379c5 100644 --- a/streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java @@ -173,7 +173,7 @@ public void shouldNotAllowOffsetsToBeUpdatedExternally() { try { offsets.put(new TopicPartition(topic, 0), 50L); fail("Should have thrown UnsupportedOperationException"); - } catch (final UnsupportedOperationException expected) {} + } catch (final UnsupportedOperationException expected) { } assertThat(collector.offsets().get(topicPartition), equalTo(2L)); }