From 30bca4a4ee8756494e0e5367ad04b0e5d9fb8aea Mon Sep 17 00:00:00 2001 From: abbccdda Date: Tue, 28 May 2019 09:55:44 -0700 Subject: [PATCH 1/2] unit test --- .../kafka/clients/consumer/KafkaConsumerTest.java | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java b/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java index 8e6bd01716a5b..154e48effa9d8 100644 --- a/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java +++ b/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java @@ -210,6 +210,18 @@ public void testInvalidSocketReceiveBufferSize() { new KafkaConsumer<>(config, new ByteArrayDeserializer(), new ByteArrayDeserializer()); } + @Test + public void testInitSuccessWithDefaultNullGroupIdAndValidGroupInstanceId() { + Map config = new HashMap<>(); + config.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, "localhost:9999"); + config.put(ConsumerConfig.SEND_BUFFER_CONFIG, Selectable.USE_DEFAULT_BUFFER_SIZE); + config.put(ConsumerConfig.RECEIVE_BUFFER_CONFIG, Selectable.USE_DEFAULT_BUFFER_SIZE); + config.put(ConsumerConfig.GROUP_INSTANCE_ID_CONFIG, "instance_id"); + KafkaConsumer consumer = new KafkaConsumer<>( + config, new ByteArrayDeserializer(), new ByteArrayDeserializer()); + consumer.close(); + } + @Test public void testSubscription() { KafkaConsumer consumer = newConsumer(groupId); From 88d9e4f905ccd027b092ddc2e2fbe8c95d66192b Mon Sep 17 00:00:00 2001 From: abbccdda Date: Tue, 28 May 2019 10:19:45 -0700 Subject: [PATCH 2/2] address comments --- .../org/apache/kafka/clients/consumer/KafkaConsumerTest.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java b/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java index 154e48effa9d8..405ec6892a2b9 100644 --- a/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java +++ b/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java @@ -211,11 +211,9 @@ public void testInvalidSocketReceiveBufferSize() { } @Test - public void testInitSuccessWithDefaultNullGroupIdAndValidGroupInstanceId() { + public void shouldIgnoreGroupInstanceIdForEmptyGroupId() { Map config = new HashMap<>(); config.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, "localhost:9999"); - config.put(ConsumerConfig.SEND_BUFFER_CONFIG, Selectable.USE_DEFAULT_BUFFER_SIZE); - config.put(ConsumerConfig.RECEIVE_BUFFER_CONFIG, Selectable.USE_DEFAULT_BUFFER_SIZE); config.put(ConsumerConfig.GROUP_INSTANCE_ID_CONFIG, "instance_id"); KafkaConsumer consumer = new KafkaConsumer<>( config, new ByteArrayDeserializer(), new ByteArrayDeserializer());