From d4b4a45313ef62918b145d48af5f6256a7bd71f3 Mon Sep 17 00:00:00 2001 From: ableegoldman Date: Thu, 23 May 2019 17:08:02 -0700 Subject: [PATCH 1/2] Updated docs --- .../main/java/org/apache/kafka/streams/StreamsBuilder.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java b/streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java index abb5aa1bbd95c..64ae739614c82 100644 --- a/streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java +++ b/streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java @@ -507,7 +507,9 @@ public synchronized StreamsBuilder addGlobalStore(final StoreBuilder storeBuilde * of the input topic. *

* The provided {@link ProcessorSupplier} will be used to create an {@link ProcessorNode} that will receive all - * records forwarded from the {@link SourceNode}. + * records forwarded from the {@link SourceNode}. NOTE: you should not use this to insert transformed records into + * the global state store. This store uses the source topic as changelog and during restore will insert records directly + * from the source. * This {@link ProcessorNode} should be used to keep the {@link StateStore} up-to-date. * The default {@link TimestampExtractor} as specified in the {@link StreamsConfig config} is used. *

From 3bd47a1f9c143d4f12cbdbcdb2d2e27b788ae726 Mon Sep 17 00:00:00 2001 From: ableegoldman Date: Fri, 24 May 2019 11:20:58 -0700 Subject: [PATCH 2/2] Github suggestion --- .../src/main/java/org/apache/kafka/streams/StreamsBuilder.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java b/streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java index 64ae739614c82..609bce5caabaa 100644 --- a/streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java +++ b/streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java @@ -507,7 +507,7 @@ public synchronized StreamsBuilder addGlobalStore(final StoreBuilder storeBuilde * of the input topic. *

* The provided {@link ProcessorSupplier} will be used to create an {@link ProcessorNode} that will receive all - * records forwarded from the {@link SourceNode}. NOTE: you should not use this to insert transformed records into + * records forwarded from the {@link SourceNode}. NOTE: you should not use the {@code Processor} to insert transformed records into * the global state store. This store uses the source topic as changelog and during restore will insert records directly * from the source. * This {@link ProcessorNode} should be used to keep the {@link StateStore} up-to-date.