From c436b2c3d47964f71d394be62182b2ebd8724d63 Mon Sep 17 00:00:00 2001 From: krezguiMT Date: Mon, 2 Apr 2018 08:26:06 +0100 Subject: [PATCH 1/2] [MINOR] refactor return value --- .../streams/processor/internals/InternalTopologyBuilder.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java b/streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java index 7d4b592b6a652..14b07b2bce037 100644 --- a/streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java +++ b/streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java @@ -1284,9 +1284,7 @@ private boolean isGlobalSource(final String nodeName) { if (nodeFactory instanceof SourceNodeFactory) { final List topics = ((SourceNodeFactory) nodeFactory).topics; - if (topics != null && topics.size() == 1 && globalTopics.contains(topics.get(0))) { - return true; - } + return topics != null && topics.size() == 1 && globalTopics.contains(topics.get(0)); } return false; From f122e0db87a3b808a2845444f7d78b7b58d877ed Mon Sep 17 00:00:00 2001 From: krezguiMT Date: Mon, 2 Apr 2018 17:20:09 +0100 Subject: [PATCH 2/2] cleanup line --- .../streams/processor/internals/InternalTopologyBuilder.java | 1 - 1 file changed, 1 deletion(-) diff --git a/streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java b/streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java index 14b07b2bce037..535f03524c06e 100644 --- a/streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java +++ b/streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java @@ -1286,7 +1286,6 @@ private boolean isGlobalSource(final String nodeName) { final List topics = ((SourceNodeFactory) nodeFactory).topics; return topics != null && topics.size() == 1 && globalTopics.contains(topics.get(0)); } - return false; }