From 26b94bd32a828895614d6f256482ffbb20690056 Mon Sep 17 00:00:00 2001 From: Ismael Juma Date: Mon, 27 Feb 2023 21:18:40 -0800 Subject: [PATCH] MINOR: srcJar should depend on processMessages task This fixes the following `./gradlew install` issue: ```text * What went wrong: A problem was found with the configuration of task ':storage:srcJar' (type 'Jar'). - Gradle detected a problem with the following location: '/Users/ijuma/src/kafka/storage/src/generated/java'. Reason: Task ':storage:srcJar' uses this output of task ':storage:processMessages' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Possible solutions: 1. Declare task ':storage:processMessages' as an input of ':storage:srcJar'. 2. Declare an explicit dependency on ':storage:processMessages' from ':storage:srcJar' using Task#dependsOn. 3. Declare an explicit dependency on ':storage:processMessages' from ':storage:srcJar' using Task#mustRunAfter. Please refer to https://docs.gradle.org/8.0.1/userguide/validation_problems.html#implicit_dependency for more details about this problem. ``` --- build.gradle | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/build.gradle b/build.gradle index 396506d1a5b82..2ed096ab5860c 100644 --- a/build.gradle +++ b/build.gradle @@ -982,6 +982,7 @@ project(':core') { } compileJava.dependsOn 'processMessages' + srcJar.dependsOn 'processMessages' task genProtocolErrorDocs(type: JavaExec) { classpath = sourceSets.main.runtimeClasspath @@ -1213,6 +1214,7 @@ project(':metadata') { } compileJava.dependsOn 'processMessages' + srcJar.dependsOn 'processMessages' sourceSets { main { @@ -1287,6 +1289,7 @@ project(':group-coordinator') { } compileJava.dependsOn 'processMessages' + srcJar.dependsOn 'processMessages' } project(':examples') { @@ -1425,6 +1428,7 @@ project(':clients') { } compileJava.dependsOn 'processMessages' + srcJar.dependsOn 'processMessages' compileTestJava.dependsOn 'processTestMessages' @@ -1527,6 +1531,7 @@ project(':raft') { } compileJava.dependsOn 'processMessages' + srcJar.dependsOn 'processMessages' jar { dependsOn createVersionFile @@ -1749,6 +1754,7 @@ project(':storage') { } compileJava.dependsOn 'processMessages' + srcJar.dependsOn 'processMessages' jar { dependsOn createVersionFile @@ -1987,6 +1993,7 @@ project(':streams') { } compileJava.dependsOn 'processMessages' + srcJar.dependsOn 'processMessages' javadoc { include "**/org/apache/kafka/streams/**"