From 672514b781b10357d374f0903d2a49b0d59ea6df Mon Sep 17 00:00:00 2001 From: Josep Prat Date: Wed, 9 Jun 2021 17:51:55 +0200 Subject: [PATCH] MINOR: clean up unneeded `@SuppressWarnings` Remove unneeded `@SuppressWarnings("unchecked")` in source and test Remove unneeded `@SuppressWarnings("deprecated")` in source and test --- .../java/org/apache/kafka/streams/StreamsConfig.java | 1 - .../internals/CogroupedStreamAggregateBuilder.java | 1 - .../internals/graph/KTableKTableJoinNode.java | 1 - .../kstream/internals/graph/ProcessorParameters.java | 1 - .../kstream/internals/graph/TableProcessorNode.java | 1 - .../processor/internals/ProcessorAdapter.java | 1 - .../processor/internals/ProcessorContextImpl.java | 1 - .../processor/internals/RecordDeserializer.java | 1 - .../streams/state/internals/RecordConverters.java | 1 - .../internals/RocksDBTimeOrderedWindowStore.java | 3 --- .../internals/TimestampedWindowStoreBuilder.java | 3 --- .../WindowToTimestampedWindowByteStoreAdapter.java | 3 --- .../org/apache/kafka/streams/KafkaStreamsTest.java | 1 - .../integration/EosV2UpgradeIntegrationTest.java | 1 - .../StandbyTaskCreationIntegrationTest.java | 1 - .../internals/InternalStreamsBuilderTest.java | 1 - .../kstream/internals/KGroupedTableImplTest.java | 3 --- .../streams/kstream/internals/KTableImplTest.java | 1 - .../internals/SessionWindowedKStreamImplTest.java | 1 - .../internals/SlidingWindowedKStreamImplTest.java | 1 - .../internals/TimeWindowedKStreamImplTest.java | 1 - .../internals/TransformerSupplierAdapterTest.java | 1 - .../SubscriptionResponseWrapperSerdeTest.java | 1 - .../foreignkeyjoin/SubscriptionWrapperSerdeTest.java | 2 -- .../internals/ProcessorContextImplTest.java | 8 ++------ .../internals/CachingPersistentWindowStoreTest.java | 12 ------------ .../state/internals/FilteredCacheIteratorTest.java | 1 - .../MeteredTimestampedKeyValueStoreTest.java | 1 - .../state/internals/RocksDBWindowStoreTest.java | 1 - .../kafka/streams/tests/StreamsUpgradeTest.java | 1 - .../StreamsUpgradeToCooperativeRebalanceTest.java | 1 - .../kafka/test/GenericInMemoryKeyValueStore.java | 1 - .../GenericInMemoryTimestampedKeyValueStore.java | 1 - 33 files changed, 2 insertions(+), 58 deletions(-) diff --git a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java index 2ef29af8b552f..cb6d58b2c694d 100644 --- a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java +++ b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java @@ -135,7 +135,6 @@ * @see ConsumerConfig * @see ProducerConfig */ -@SuppressWarnings("deprecation") public class StreamsConfig extends AbstractConfig { private static final Logger log = LoggerFactory.getLogger(StreamsConfig.class); diff --git a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java index c7585263a718a..6cb529dfcf904 100644 --- a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java +++ b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java @@ -48,7 +48,6 @@ class CogroupedStreamAggregateBuilder { CogroupedStreamAggregateBuilder(final InternalStreamsBuilder builder) { this.builder = builder; } - @SuppressWarnings("unchecked") KTable build(final Map, Aggregator> groupPatterns, final Initializer initializer, final NamedInternal named, diff --git a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/KTableKTableJoinNode.java b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/KTableKTableJoinNode.java index 0ca1e35f3b9f9..ac8d82101d0eb 100644 --- a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/KTableKTableJoinNode.java +++ b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/KTableKTableJoinNode.java @@ -209,7 +209,6 @@ public KTableKTableJoinNodeBuilder withStoreBuilder(final StoreBu return this; } - @SuppressWarnings("unchecked") public KTableKTableJoinNode build() { return new KTableKTableJoinNode<>( nodeName, diff --git a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/ProcessorParameters.java b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/ProcessorParameters.java index 018d2b7dc7dd3..ec2ce48f11e83 100644 --- a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/ProcessorParameters.java +++ b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/ProcessorParameters.java @@ -60,7 +60,6 @@ public org.apache.kafka.streams.processor.ProcessorSupplier oldProcess return oldProcessorSupplier; } - @SuppressWarnings("unchecked") KTableSource kTableSourceSupplier() { // This cast always works because KTableSource hasn't been converted yet. return oldProcessorSupplier == null diff --git a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/TableProcessorNode.java b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/TableProcessorNode.java index 5254c5757f1b9..f13631ff53b5b 100644 --- a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/TableProcessorNode.java +++ b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/TableProcessorNode.java @@ -57,7 +57,6 @@ public String toString() { "} " + super.toString(); } - @SuppressWarnings("unchecked") @Override public void writeToTopology(final InternalTopologyBuilder topologyBuilder, final Properties props) { final String processorName = processorParameters.processorName(); diff --git a/streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorAdapter.java b/streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorAdapter.java index f067bbda6472d..687e92f0ddb83 100644 --- a/streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorAdapter.java +++ b/streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorAdapter.java @@ -46,7 +46,6 @@ private ProcessorAdapter(final org.apache.kafka.streams.processor.Processor context) { // It only makes sense to use this adapter internally to Streams, in which case diff --git a/streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java b/streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java index bd7ece4411513..ce06cb189df27 100644 --- a/streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java +++ b/streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java @@ -263,7 +263,6 @@ public void commit() { streamTask.requestCommit(); } - @SuppressWarnings("deprecation") // removing #schedule(final long intervalMs,...) will fix this @Override public Cancellable schedule(final Duration interval, final PunctuationType type, diff --git a/streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordDeserializer.java b/streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordDeserializer.java index a965187228a37..b5c821ae4c0dc 100644 --- a/streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordDeserializer.java +++ b/streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordDeserializer.java @@ -50,7 +50,6 @@ class RecordDeserializer { * {@link DeserializationExceptionHandler.DeserializationHandlerResponse#FAIL FAIL} * or throws an exception itself */ - @SuppressWarnings("deprecation") ConsumerRecord deserialize(final ProcessorContext processorContext, final ConsumerRecord rawRecord) { diff --git a/streams/src/main/java/org/apache/kafka/streams/state/internals/RecordConverters.java b/streams/src/main/java/org/apache/kafka/streams/state/internals/RecordConverters.java index 1f2e5930a211b..ad3c91e8073ff 100644 --- a/streams/src/main/java/org/apache/kafka/streams/state/internals/RecordConverters.java +++ b/streams/src/main/java/org/apache/kafka/streams/state/internals/RecordConverters.java @@ -23,7 +23,6 @@ public final class RecordConverters { private static final RecordConverter IDENTITY_INSTANCE = record -> record; - @SuppressWarnings("deprecation") private static final RecordConverter RAW_TO_TIMESTAMED_INSTANCE = record -> { final byte[] rawValue = record.value(); final long timestamp = record.timestamp(); diff --git a/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedWindowStore.java b/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedWindowStore.java index f8ba8837258f3..37aaa27e2f89c 100644 --- a/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedWindowStore.java +++ b/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedWindowStore.java @@ -66,7 +66,6 @@ public byte[] fetch(final Bytes key, final long timestamp) { throw new UnsupportedOperationException(); } - @SuppressWarnings("deprecation") @Override public WindowStoreIterator fetch(final Bytes key, final long timeFrom, final long timeTo) { throw new UnsupportedOperationException(); @@ -77,7 +76,6 @@ public WindowStoreIterator backwardFetch(final Bytes key, final long tim throw new UnsupportedOperationException(); } - @SuppressWarnings("deprecation") // note, this method must be kept if super#fetch(...) is removed @Override public KeyValueIterator, byte[]> fetch(final Bytes keyFrom, final Bytes keyTo, @@ -105,7 +103,6 @@ public KeyValueIterator, byte[]> backwardAll() { throw new UnsupportedOperationException(); } - @SuppressWarnings("deprecation") // note, this method must be kept if super#fetchAll(...) is removed @Override public KeyValueIterator, byte[]> fetchAll(final long timeFrom, final long timeTo) { throw new UnsupportedOperationException(); diff --git a/streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedWindowStoreBuilder.java b/streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedWindowStoreBuilder.java index 417b45b46cc7e..b3727f55c01bb 100644 --- a/streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedWindowStoreBuilder.java +++ b/streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedWindowStoreBuilder.java @@ -135,7 +135,6 @@ public byte[] fetch(final Bytes key, return wrapped.fetch(key, time); } - @SuppressWarnings("deprecation") @Override public WindowStoreIterator fetch(final Bytes key, final long timeFrom, @@ -150,7 +149,6 @@ public WindowStoreIterator backwardFetch(final Bytes key, return wrapped.backwardFetch(key, timeFrom, timeTo); } - @SuppressWarnings("deprecation") @Override public KeyValueIterator, byte[]> fetch(final Bytes keyFrom, final Bytes keyTo, @@ -167,7 +165,6 @@ public KeyValueIterator, byte[]> backwardFetch(final Bytes keyFr return wrapped.backwardFetch(keyFrom, keyTo, timeFrom, timeTo); } - @SuppressWarnings("deprecation") @Override public KeyValueIterator, byte[]> fetchAll(final long timeFrom, final long timeTo) { diff --git a/streams/src/main/java/org/apache/kafka/streams/state/internals/WindowToTimestampedWindowByteStoreAdapter.java b/streams/src/main/java/org/apache/kafka/streams/state/internals/WindowToTimestampedWindowByteStoreAdapter.java index 8d895fc7f88e7..f7999d3a449c8 100644 --- a/streams/src/main/java/org/apache/kafka/streams/state/internals/WindowToTimestampedWindowByteStoreAdapter.java +++ b/streams/src/main/java/org/apache/kafka/streams/state/internals/WindowToTimestampedWindowByteStoreAdapter.java @@ -54,7 +54,6 @@ public byte[] fetch(final Bytes key, } @Override - @SuppressWarnings("deprecation") public WindowStoreIterator fetch(final Bytes key, final long timeFrom, final long timeTo) { @@ -83,7 +82,6 @@ public WindowStoreIterator backwardFetch(final Bytes key, } @Override - @SuppressWarnings("deprecation") public KeyValueIterator, byte[]> fetch(final Bytes keyFrom, final Bytes keyTo, final long timeFrom, @@ -126,7 +124,6 @@ public KeyValueIterator, byte[]> backwardAll() { } @Override - @SuppressWarnings("deprecation") public KeyValueIterator, byte[]> fetchAll(final long timeFrom, final long timeTo) { return new KeyValueToTimestampedKeyValueIteratorAdapter<>(store.fetchAll(timeFrom, timeTo)); diff --git a/streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java b/streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java index 300a9e90542a9..54a15cc062023 100644 --- a/streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java @@ -1079,7 +1079,6 @@ public void shouldTransitToRunningWithGlobalOnlyTopology() throws InterruptedExc } } - @SuppressWarnings("unchecked") @Deprecated // testing old PAPI private Topology getStatefulTopology(final String inputTopic, final String outputTopic, diff --git a/streams/src/test/java/org/apache/kafka/streams/integration/EosV2UpgradeIntegrationTest.java b/streams/src/test/java/org/apache/kafka/streams/integration/EosV2UpgradeIntegrationTest.java index 4543b99b0da74..b6aab860eac85 100644 --- a/streams/src/test/java/org/apache/kafka/streams/integration/EosV2UpgradeIntegrationTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/integration/EosV2UpgradeIntegrationTest.java @@ -875,7 +875,6 @@ private KafkaStreams getKafkaStreams(final String appDir, final KStream input = builder.stream(MULTI_PARTITION_INPUT_TOPIC); input.transform(new TransformerSupplier>() { - @SuppressWarnings("unchecked") @Override public Transformer> get() { return new Transformer>() { diff --git a/streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskCreationIntegrationTest.java b/streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskCreationIntegrationTest.java index ab22ae6b605d7..f924e08b85efe 100644 --- a/streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskCreationIntegrationTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskCreationIntegrationTest.java @@ -105,7 +105,6 @@ public void shouldNotCreateAnyStandByTasksForStateStoreWithLoggingDisabled() thr builder.addStateStore(keyValueStoreBuilder); builder.stream(INPUT_TOPIC, Consumed.with(Serdes.Integer(), Serdes.Integer())) .transform(() -> new Transformer>() { - @SuppressWarnings("unchecked") @Override public void init(final ProcessorContext context) {} diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilderTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilderTest.java index 1fffb500a74c4..76ae717a56061 100644 --- a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilderTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilderTest.java @@ -51,7 +51,6 @@ import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; -@SuppressWarnings("unchecked") public class InternalStreamsBuilderTest { private static final String APP_ID = "app-id"; diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KGroupedTableImplTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KGroupedTableImplTest.java index 130e299ff8835..ee4b1365e821c 100644 --- a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KGroupedTableImplTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KGroupedTableImplTest.java @@ -201,7 +201,6 @@ public void shouldReduceWithInternalStoreName() { } } - @SuppressWarnings("unchecked") @Test public void shouldReduceAndMaterializeResults() { final KeyValueMapper> intProjection = @@ -235,7 +234,6 @@ public void shouldReduceAndMaterializeResults() { } } - @SuppressWarnings("unchecked") @Test public void shouldCountAndMaterializeResults() { builder @@ -265,7 +263,6 @@ public void shouldCountAndMaterializeResults() { } } - @SuppressWarnings("unchecked") @Test public void shouldAggregateAndMaterializeResults() { builder diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java index b979d3ecd7734..1885d57ab5b79 100644 --- a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java @@ -574,7 +574,6 @@ public void shouldThrowNullPointerOnTransformValuesWithKeyWhenMaterializedIsNull assertThrows(NullPointerException.class, () -> table.transformValues(valueTransformerSupplier, (Materialized) null)); } - @SuppressWarnings("unchecked") @Test public void shouldThrowNullPointerOnTransformValuesWithKeyWhenStoreNamesNull() { final ValueTransformerWithKeySupplier valueTransformerSupplier = diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/SessionWindowedKStreamImplTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/SessionWindowedKStreamImplTest.java index d6e56ba5b6128..abca688d2d54c 100644 --- a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/SessionWindowedKStreamImplTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/SessionWindowedKStreamImplTest.java @@ -283,7 +283,6 @@ public void shouldThrowNullPointerOnMaterializedReduceIfMaterializedIsNull() { } @Test - @SuppressWarnings("unchecked") public void shouldThrowNullPointerOnMaterializedReduceIfNamedIsNull() { assertThrows(NullPointerException.class, () -> stream.reduce(MockReducer.STRING_ADDER, (Named) null)); } diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImplTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImplTest.java index d6b26bf2a7c59..f012cedcf4391 100644 --- a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImplTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImplTest.java @@ -361,7 +361,6 @@ public void shouldThrowNullPointerOnMaterializedReduceIfMaterializedIsNull() { } @Test - @SuppressWarnings("unchecked") public void shouldThrowNullPointerOnMaterializedReduceIfNamedIsNull() { assertThrows(NullPointerException.class, () -> windowedStream.reduce(MockReducer.STRING_ADDER, (Named) null)); } diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/TimeWindowedKStreamImplTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/TimeWindowedKStreamImplTest.java index c35da00697ba5..38fda9d6da21c 100644 --- a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/TimeWindowedKStreamImplTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/TimeWindowedKStreamImplTest.java @@ -300,7 +300,6 @@ public void shouldThrowNullPointerOnMaterializedReduceIfMaterializedIsNull() { } @Test - @SuppressWarnings("unchecked") public void shouldThrowNullPointerOnMaterializedReduceIfNamedIsNull() { assertThrows(NullPointerException.class, () -> windowedStream.reduce( MockReducer.STRING_ADDER, diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/TransformerSupplierAdapterTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/TransformerSupplierAdapterTest.java index 115855d964582..1eb55d0a08945 100644 --- a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/TransformerSupplierAdapterTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/TransformerSupplierAdapterTest.java @@ -34,7 +34,6 @@ import static org.hamcrest.core.IsNot.not; import static org.hamcrest.MatcherAssert.assertThat; -@SuppressWarnings("unchecked") public class TransformerSupplierAdapterTest extends EasyMockSupport { private ProcessorContext context; diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerdeTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerdeTest.java index 1bd1bd27cf7cc..30fc0c318519c 100644 --- a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerdeTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerdeTest.java @@ -127,7 +127,6 @@ public void shouldSerdeWithNullsTest() { } @Test - @SuppressWarnings("unchecked") public void shouldThrowExceptionWithBadVersionTest() { final long[] hashedValue = null; assertThrows(UnsupportedVersionException.class, diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionWrapperSerdeTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionWrapperSerdeTest.java index b7ce34f0d1030..e937efe2bc092 100644 --- a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionWrapperSerdeTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionWrapperSerdeTest.java @@ -59,7 +59,6 @@ public void shouldSerdeNullHashTest() { } @Test - @SuppressWarnings("unchecked") public void shouldThrowExceptionOnNullKeyTest() { final String originalKey = null; final long[] hashedValue = Murmur3.hash128(new byte[] {(byte) 0xFF, (byte) 0xAA, (byte) 0x00, (byte) 0x19}); @@ -68,7 +67,6 @@ public void shouldThrowExceptionOnNullKeyTest() { } @Test - @SuppressWarnings("unchecked") public void shouldThrowExceptionOnNullInstructionTest() { final String originalKey = "originalKey"; final long[] hashedValue = Murmur3.hash128(new byte[] {(byte) 0xFF, (byte) 0xAA, (byte) 0x00, (byte) 0x19}); diff --git a/streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorContextImplTest.java b/streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorContextImplTest.java index 9412e55e0ff60..13816d740a62b 100644 --- a/streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorContextImplTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorContextImplTest.java @@ -220,7 +220,6 @@ public void globalTimestampedKeyValueStoreShouldBeReadOnly() { } @Test - @SuppressWarnings("deprecation") public void globalWindowStoreShouldBeReadOnly() { doTest("GlobalWindowStore", (Consumer>) store -> { verifyStoreCannotBeInitializedOrClosed(store); @@ -238,7 +237,6 @@ public void globalWindowStoreShouldBeReadOnly() { @Test - @SuppressWarnings("deprecation") public void globalTimestampedWindowStoreShouldBeReadOnly() { doTest("GlobalTimestampedWindowStore", (Consumer>) store -> { verifyStoreCannotBeInitializedOrClosed(store); @@ -325,7 +323,6 @@ public void localTimestampedKeyValueStoreShouldNotAllowInitOrClose() { } @Test - @SuppressWarnings("deprecation") public void localWindowStoreShouldNotAllowInitOrClose() { doTest("LocalWindowStore", (Consumer>) store -> { verifyStoreCannotBeInitializedOrClosed(store); @@ -345,7 +342,6 @@ public void localWindowStoreShouldNotAllowInitOrClose() { } @Test - @SuppressWarnings("deprecation") public void localTimestampedWindowStoreShouldNotAllowInitOrClose() { doTest("LocalTimestampedWindowStore", (Consumer>) store -> { verifyStoreCannotBeInitializedOrClosed(store); @@ -615,7 +611,7 @@ private TimestampedKeyValueStore timestampedKeyValueStoreMock() { return timestampedKeyValueStoreMock; } - @SuppressWarnings({"unchecked", "deprecation"}) + @SuppressWarnings("unchecked") private WindowStore windowStoreMock() { final WindowStore windowStore = mock(WindowStore.class); @@ -638,7 +634,7 @@ private WindowStore windowStoreMock() { return windowStore; } - @SuppressWarnings({"unchecked", "deprecation"}) + @SuppressWarnings("unchecked") private TimestampedWindowStore timestampedWindowStoreMock() { final TimestampedWindowStore windowStore = mock(TimestampedWindowStore.class); diff --git a/streams/src/test/java/org/apache/kafka/streams/state/internals/CachingPersistentWindowStoreTest.java b/streams/src/test/java/org/apache/kafka/streams/state/internals/CachingPersistentWindowStoreTest.java index ef9345b849e36..2de66fb2fc952 100644 --- a/streams/src/test/java/org/apache/kafka/streams/state/internals/CachingPersistentWindowStoreTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/state/internals/CachingPersistentWindowStoreTest.java @@ -235,7 +235,6 @@ public void close() { } @Test - @SuppressWarnings("deprecation") public void shouldPutFetchFromCache() { cachingStore.put(bytesKey("a"), bytesValue("a"), DEFAULT_TIMESTAMP); cachingStore.put(bytesKey("b"), bytesValue("b"), DEFAULT_TIMESTAMP); @@ -274,7 +273,6 @@ private String stringFrom(final byte[] from) { } @Test - @SuppressWarnings("deprecation") public void shouldPutFetchRangeFromCache() { cachingStore.put(bytesKey("a"), bytesValue("a"), DEFAULT_TIMESTAMP); cachingStore.put(bytesKey("b"), bytesValue("b"), DEFAULT_TIMESTAMP); @@ -316,7 +314,6 @@ public void shouldGetAllFromCache() { } @Test - @SuppressWarnings("deprecation") public void shouldGetAllBackwardFromCache() { cachingStore.put(bytesKey("a"), bytesValue("a"), DEFAULT_TIMESTAMP); cachingStore.put(bytesKey("b"), bytesValue("b"), DEFAULT_TIMESTAMP); @@ -339,7 +336,6 @@ public void shouldGetAllBackwardFromCache() { } @Test - @SuppressWarnings("deprecation") public void shouldFetchAllWithinTimestampRange() { final String[] array = {"a", "b", "c", "d", "e", "f", "g", "h"}; for (int i = 0; i < array.length; i++) { @@ -381,7 +377,6 @@ public void shouldFetchAllWithinTimestampRange() { } @Test - @SuppressWarnings("deprecation") public void shouldFetchAllBackwardWithinTimestampRange() { final String[] array = {"a", "b", "c", "d", "e", "f", "g", "h"}; for (int i = 0; i < array.length; i++) { @@ -438,7 +433,6 @@ public void shouldFlushEvictedItemsIntoUnderlyingStore() { } @Test - @SuppressWarnings("deprecation") public void shouldForwardDirtyItemsWhenFlushCalled() { final Windowed windowedKey = new Windowed<>("1", new TimeWindow(DEFAULT_TIMESTAMP, DEFAULT_TIMESTAMP + WINDOW_SIZE)); @@ -455,7 +449,6 @@ public void shouldSetFlushListener() { } @Test - @SuppressWarnings("deprecation") public void shouldForwardOldValuesWhenEnabled() { cachingStore.setFlushListener(cacheListener, true); final Windowed windowedKey = @@ -484,7 +477,6 @@ public void shouldForwardOldValuesWhenEnabled() { } @Test - @SuppressWarnings("deprecation") public void shouldForwardOldValuesWhenDisabled() { final Windowed windowedKey = new Windowed<>("1", new TimeWindow(DEFAULT_TIMESTAMP, DEFAULT_TIMESTAMP + WINDOW_SIZE)); @@ -615,7 +607,6 @@ public void shouldIterateBackwardCacheAndStoreKeyRange() { } @Test - @SuppressWarnings("deprecation") public void shouldClearNamespaceCacheOnClose() { cachingStore.put(bytesKey("a"), bytesValue("a"), 0L); assertEquals(1, cache.size()); @@ -636,7 +627,6 @@ public void shouldThrowIfTryingToFetchRangeFromClosedCachingStore() { } @Test - @SuppressWarnings("deprecation") public void shouldThrowIfTryingToWriteToClosedCachingStore() { cachingStore.close(); assertThrows(InvalidStateStoreException.class, () -> cachingStore.put(bytesKey("a"), bytesValue("a"), 0L)); @@ -785,13 +775,11 @@ public void shouldReturnSameResultsForSingleKeyFetchAndEqualKeyRangeBackwardFetc } @Test - @SuppressWarnings("deprecation") public void shouldThrowNullPointerExceptionOnPutNullKey() { assertThrows(NullPointerException.class, () -> cachingStore.put(null, bytesValue("anyValue"), 0L)); } @Test - @SuppressWarnings("deprecation") public void shouldNotThrowNullPointerExceptionOnPutNullValue() { cachingStore.put(bytesKey("a"), null, 0L); } diff --git a/streams/src/test/java/org/apache/kafka/streams/state/internals/FilteredCacheIteratorTest.java b/streams/src/test/java/org/apache/kafka/streams/state/internals/FilteredCacheIteratorTest.java index f49d881f94236..bd794333660fc 100644 --- a/streams/src/test/java/org/apache/kafka/streams/state/internals/FilteredCacheIteratorTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/state/internals/FilteredCacheIteratorTest.java @@ -50,7 +50,6 @@ public Bytes cacheKey(final Bytes key) { } }; - @SuppressWarnings("unchecked") private final KeyValueStore store = new GenericInMemoryKeyValueStore<>("my-store"); private final KeyValue firstEntry = KeyValue.pair(Bytes.wrap("a".getBytes()), new LRUCacheEntry("1".getBytes())); diff --git a/streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStoreTest.java b/streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStoreTest.java index eb48e0c5fc2fa..bce87ef2fbeec 100644 --- a/streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStoreTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStoreTest.java @@ -426,7 +426,6 @@ private KafkaMetric metric(final MetricName metricName) { } @Test - @SuppressWarnings("unchecked") public void shouldNotThrowExceptionIfSerdesCorrectlySetFromProcessorContext() { final MeteredTimestampedKeyValueStore store = new MeteredTimestampedKeyValueStore<>( inner, diff --git a/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBWindowStoreTest.java b/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBWindowStoreTest.java index 2b890f172d500..3bb9f14e66827 100644 --- a/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBWindowStoreTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBWindowStoreTest.java @@ -43,7 +43,6 @@ import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; -@SuppressWarnings("PointlessArithmeticExpression") public class RocksDBWindowStoreTest extends AbstractWindowBytesStoreTest { private static final String STORE_NAME = "rocksDB window store"; diff --git a/streams/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java b/streams/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java index 2ad07f2fa3e4a..2fabf97925ea6 100644 --- a/streams/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java @@ -65,7 +65,6 @@ public class StreamsUpgradeTest { - @SuppressWarnings("unchecked") public static void main(final String[] args) throws Exception { if (args.length < 1) { System.err.println("StreamsUpgradeTest requires one argument (properties-file) but no provided: "); diff --git a/streams/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeToCooperativeRebalanceTest.java b/streams/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeToCooperativeRebalanceTest.java index bd5752aa30d86..19e81acd8a2f1 100644 --- a/streams/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeToCooperativeRebalanceTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeToCooperativeRebalanceTest.java @@ -37,7 +37,6 @@ public class StreamsUpgradeToCooperativeRebalanceTest { - @SuppressWarnings("unchecked") public static void main(final String[] args) throws Exception { if (args.length < 1) { System.err.println("StreamsUpgradeToCooperativeRebalanceTest requires one argument (properties-file) but no args provided"); diff --git a/streams/src/test/java/org/apache/kafka/test/GenericInMemoryKeyValueStore.java b/streams/src/test/java/org/apache/kafka/test/GenericInMemoryKeyValueStore.java index 72e6c266fea8c..d9a2afe0f5884 100644 --- a/streams/src/test/java/org/apache/kafka/test/GenericInMemoryKeyValueStore.java +++ b/streams/src/test/java/org/apache/kafka/test/GenericInMemoryKeyValueStore.java @@ -60,7 +60,6 @@ public String name() { @Deprecated @Override - @SuppressWarnings("unchecked") /* This is a "dummy" store used for testing; it does not support restoring from changelog since we allow it to be serde-ignorant */ public void init(final ProcessorContext context, final StateStore root) { diff --git a/streams/src/test/java/org/apache/kafka/test/GenericInMemoryTimestampedKeyValueStore.java b/streams/src/test/java/org/apache/kafka/test/GenericInMemoryTimestampedKeyValueStore.java index c77cbacb1db24..2198d181dd8d3 100644 --- a/streams/src/test/java/org/apache/kafka/test/GenericInMemoryTimestampedKeyValueStore.java +++ b/streams/src/test/java/org/apache/kafka/test/GenericInMemoryTimestampedKeyValueStore.java @@ -61,7 +61,6 @@ public String name() { @Deprecated @Override - @SuppressWarnings("unchecked") /* This is a "dummy" store used for testing; it does not support restoring from changelog since we allow it to be serde-ignorant */ public void init(final ProcessorContext context, final StateStore root) {