[Contrib] Fix error message at callback_get_section_size() #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @weberlo can you take a look? |
weberlo
approved these changes
Nov 6, 2019
|
LGTM. Thanks for the fix! |
tqchen
approved these changes
Nov 6, 2019
|
Thanks @cchung100m @weberlo |
zxy844288792
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Nov 13, 2019
* [Contrib] Fix error message at callback_get_section_size() * Trigger notification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kevinthesun
This PR improves the error message for raising
RuntimeErrorwhen callingcallback_get_section_size, I would appreciate if you can help to review/manage it.many thanks,