Fix infer type of kernel in dense. #4125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anijain2305 can you take a look at this pr. |
anijain2305
reviewed
Oct 15, 2019
… the branches now. - Adding test case for validating that data dtype and kernel dtypes can be different.
|
Add test case and adde chekc for weight being valid. |
…e will use the data dtype.
anijain2305
approved these changes
Oct 15, 2019
|
LGTM. Thanks @shoubhik for the changes. |
yzhliu
approved these changes
Oct 15, 2019
zhiics
added
status: accepted
and removed
status: need test case
anijain2305
pushed a commit
to anijain2305/tvm
that referenced
this pull request
Oct 17, 2019
* Fix infer type of kernel in dense. * - Moving the check of weight being nullptr up as it is needed in both the branches now. - Adding test case for validating that data dtype and kernel dtypes can be different. * - Fix the dtype check for weight. If the weight is not present then we will use the data dtype.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Oct 18, 2019
* Fix infer type of kernel in dense. * - Moving the check of weight being nullptr up as it is needed in both the branches now. - Adding test case for validating that data dtype and kernel dtypes can be different. * - Fix the dtype check for weight. If the weight is not present then we will use the data dtype.
petrex
added a commit
to petrex/tvm
that referenced
this pull request
Oct 29, 2019
* master: (51 commits) [QNN][TFLite] Parsing QNN Add op. Adding MobilenetV2. (apache#4142) [CI] Pin NNPack pthreadtools version (apache#4152) Fix typo (apache#4144) [Relay][Frontend][TF] Add tensor array ops (apache#3798) [relay][vm] Separate VM runtime with executable (apache#4100) [PATCH] Fix undefined __floatdihf in libtvmruntime.so on aarch64. (apache#4119) [DOCKER] Pin torchvision==0.4.1 (apache#4140) [TOPI][x86] Cascade lake support. (apache#4123) [Relay] Improve build error when no lowered funcs are produced (apache#4132) [RUNTIME] Refactor object python FFI to new protocol. (apache#4128) Update PULL_REQUEST_TEMPLATE.md Adding support for dequantizing from int32 to float32. (apache#4130) [Relay][Training] Add and fix gradients (apache#4126) [QNN] Change default rouning to UPWARD. (apache#4131) Fix infer type of kernel in dense. (apache#4125) [Relay][AlterOpLayout] NHWC to NCHWc pad operator. (apache#4103) [ARITH] Fix lowering of floormod(x, y) != 0 (apache#4127) [RFC][RUNTIME] Introduce new object protocol. (apache#4115) [Relay][Topi] Disable conv NHWC pack int8. (apache#4038) Update task_cpp_unittest.sh ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of quantization the kernel and data dtypes can be different (uint8 vs int8). So we can no longer make the assumption that kernel dtype will be the same as data dtype.
In this PR we correctly assign the weight dtype to
weight->dtype