-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARITH] Refactor to use explicit div/mod functions instead of operators. #4000
Conversation
cc @yzhliu @icemelon9 @wweic @xqdan @sgrechanik-h @derisavi @umangyadav @icemelon9 @kazum |
This looks really great @tqchen. |
Additional notes on division modes:
So we have to make the choice of division mode for index calculations. indexdiv/mod tries to isolate that choice into a single place. It also brings additional information to the function that a and b are non-negative at the moment we call the function.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…rs. (apache#4000) * [ARITH] Use explicit div/mod functions instead of operators. * fix pooling case
…rs. (apache#4000) * [ARITH] Use explicit div/mod functions instead of operators. * fix pooling case
…rs. (apache#4000) * [ARITH] Use explicit div/mod functions instead of operators. * fix pooling case
This PR is part of #3977
Summary of changes: