Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add test script starter command to document #3993

Merged
merged 1 commit into from
Sep 24, 2019
Merged

[DOC] Add test script starter command to document #3993

merged 1 commit into from
Sep 24, 2019

Conversation

standbyme
Copy link
Contributor

It makes this document more operative.

@standbyme
Copy link
Contributor Author

@zhiics Please review this PR.
Thanks for your help! : )

Copy link
Member

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@standbyme Thanks for contribution. LGTM.

@zhiics
Copy link
Member

zhiics commented Sep 23, 2019

@standbyme Hmm, I realized that the previous description was actually okay as well, because you can compile the c++ gtests that way. The script you put actually both compiles and runs all c++ unit test. Could you please rephrase this sentence to something that reflects both? Thanks.

@standbyme
Copy link
Contributor Author

@zhiics How about this one? : )

Copy link
Member

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks.

@zhiics zhiics merged commit 3f7cbed into apache:master Sep 24, 2019
@standbyme standbyme deleted the patch-1 branch September 24, 2019 06:38
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 30, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 30, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants