Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add operator isnan #3979

Merged
merged 4 commits into from
Sep 22, 2019
Merged

Add operator isnan #3979

merged 4 commits into from
Sep 22, 2019

Conversation

hgt312
Copy link
Contributor

@hgt312 hgt312 commented Sep 20, 2019

tqchen
tqchen requested changes Sep 20, 2019
View reviewed changes
Copy link
Member

@tqchen tqchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add a testcase to it

src/codegen/codegen_c.cc Outdated Show resolved Hide resolved
@tqchen tqchen added status: need test case need test cases to cover the change status: need update need update based on feedbacks labels Sep 20, 2019
@hgt312
Copy link
Contributor Author

hgt312 commented Sep 21, 2019

also add isnan to topi

@hgt312 hgt312 requested a review from tqchen September 21, 2019 05:52
@tqchen tqchen merged commit 16d4da4 into apache:master Sep 22, 2019
@tqchen
Copy link
Member

tqchen commented Sep 22, 2019 •
edited
Loading

THANKS @hgt312 ! Also thanks @ajtulloch @FrozenGene for helpful discussions in https://discuss.tvm.ai/t/is-there-a-good-way-to-implement-isnan-op/4050

@tqchen tqchen added status: accepted and removed status: need test case need test cases to cover the change status: need update need update based on feedbacks labels Sep 22, 2019
@hgt312 hgt312 deleted the expr_isnan branch September 24, 2019 03:43
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 30, 2019
@hgt312 @wweic
Add operator isnan (apache#3979)
4dbfba5 
* add expr `isnan`

* move to intrinsic

* doc & add to topi

* fix error from ci
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 30, 2019
@hgt312 @wweic
Add operator isnan (apache#3979)
2e91477 
* add expr `isnan`

* move to intrinsic

* doc & add to topi

* fix error from ci
wweic pushed a commit to neo-ai/tvm that referenced this pull request Oct 1, 2019
@hgt312 @wweic
Add operator isnan (apache#3979)
e7ca2e1 
* add expr `isnan`

* move to intrinsic

* doc & add to topi

* fix error from ci
@tqchen tqchen mentioned this pull request Nov 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqchen tqchen tqchen approved these changes

@Huyuwei Huyuwei Awaiting requested review from Huyuwei

@Laurawly Laurawly Awaiting requested review from Laurawly

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hgt312 @tqchen