Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relay] Legalize and AlterOpLayout for Int8 Intel. #3961

Merged
merged 1 commit into from
Sep 19, 2019
Merged

[Relay] Legalize and AlterOpLayout for Int8 Intel. #3961

merged 1 commit into from
Sep 19, 2019

Conversation

anijain2305
Copy link
Contributor

@anijain2305 anijain2305 commented Sep 16, 2019 •
edited
Loading

Couple of changes

  • Legalize and Alter op layout in a separate file for better organization.
  • For Int8, legalize pass that inserts pad for cases where input channel is not multiple of 4 and output_channel is not multiple of 16.
  • Fallback schedule for Int8 - as the ic_bn % 4 == 0 and oc_bn % 16 == 0
  • Sweep tests for int8 over input channel, output channel and layout

@yzhliu @kevinthesun

@anijain2305 anijain2305 force-pushed the legal_int8 branch 5 times, most recently from 003c628 to db1f46a Compare September 17, 2019 22:50
yzhliu
yzhliu reviewed Sep 18, 2019
View reviewed changes
topi/python/topi/x86/conv2d_alter_layout.py Outdated
# specific language governing permissions and limitations
# under the License.
# pylint: disable=invalid-name,unused-variable,unused-argument,no-member
"""Conv2D alter op and legalize functions for x86"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we name the file "conv2d_alter_op.py" instead (as it contains legalize)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@yzhliu yzhliu merged commit b0ddcff into apache:master Sep 19, 2019
@yzhliu
Copy link
Member

yzhliu commented Sep 19, 2019

Thanks @anijain2305

tqchen pushed a commit to tqchen/tvm that referenced this pull request Sep 20, 2019
@anijain2305 @tqchen
[Relay] Legalize and AlterOpLayout for Int8 Intel. (apache#3961)
a9a80dc
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 30, 2019
@anijain2305 @wweic
[Relay] Legalize and AlterOpLayout for Int8 Intel. (apache#3961)
12787d9
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 30, 2019
@anijain2305 @wweic
[Relay] Legalize and AlterOpLayout for Int8 Intel. (apache#3961)
2f2c2fb
wweic pushed a commit to neo-ai/tvm that referenced this pull request Oct 1, 2019
@anijain2305 @wweic
[Relay] Legalize and AlterOpLayout for Int8 Intel. (apache#3961)
a439c78
@tqchen tqchen mentioned this pull request Nov 8, 2019
Closed
@anijain2305 anijain2305 deleted the legal_int8 branch November 13, 2019 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzhliu yzhliu yzhliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anijain2305 @yzhliu