Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qnn dequantize with min max using Mxnet flavor to support Mxnet prequantized models. #3945

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

shoubhik
Copy link
Contributor

  • Adding support for Mxnet flavored dequantization for both default a…nd using MKLDNN. User can choose between the two at runtime.

  • Added tests for new methods added.

…nd using MKLDNN. User can choose between the two at runtime.

- Added tests for new methods added.
@shoubhik
Copy link
Contributor Author

@anijain2305 can you take a look at the final PR.

Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anijain2305
Copy link
Contributor

@yzhliu Can you please review this? This is for reading an MxNet quantized graph

@shoubhik
Copy link
Contributor Author

@yzhliu Can you please review this?

@wweic
Copy link
Contributor

wweic commented Oct 10, 2019

@yzhliu @icemelon9 @kevinthesun @zhiics ping

@tqchen tqchen merged commit 9bbc98c into apache:master Oct 10, 2019
@tqchen
Copy link
Member

tqchen commented Oct 10, 2019

Thanks @wweic @shoubhik @anijain2305

anijain2305 pushed a commit to anijain2305/tvm that referenced this pull request Oct 17, 2019
…nd using MKLDNN. User can choose between the two at runtime. (apache#3945)

- Added tests for new methods added.
wweic pushed a commit to neo-ai/tvm that referenced this pull request Oct 18, 2019
…nd using MKLDNN. User can choose between the two at runtime. (apache#3945)

- Added tests for new methods added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants