Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TFLite] Support depthwise convolution multiplier greater than 1 #3922

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

FrozenGene
Copy link
Member

Currently, TFLite FE only support depthwise convolution multiplier equals to 1. However, community users report we need this feature and Tensorflow FE has supported it too recently. This PR does support this.

Related links and discussions:

  1. https://discuss.tvm.ai/t/deployment-of-converted-pb-file-to-tflite-using-relay-frontend-from-tflite/3307/
  2. https://discuss.tvm.ai/t/tf-kernel-layout-hwio-vs-hwoi/3895

cc: @tmoreau89

Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution :)

@FrozenGene
Copy link
Member Author

@yzh119 @tqchen @kevinthesun @icemelon9 could someone help to manage it? Thanks.

Copy link
Contributor

@cchung100m cchung100m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and LGTM :)

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FrozenGene for the changes and following up on our earlier conversation. The changes LGTM.

@tmoreau89 tmoreau89 merged commit 968ffef into apache:master Sep 11, 2019
@FrozenGene FrozenGene deleted the tflite_depthwise branch September 12, 2019 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants