Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relay][Frontend][Keras] Fix ReLU in Keras Converter missed the case #3917

Merged
merged 3 commits into from
Sep 10, 2019
Merged

[Relay][Frontend][Keras] Fix ReLU in Keras Converter missed the case #3917

merged 3 commits into from
Sep 10, 2019

Conversation

cchung100m
Copy link
Contributor

@cchung100m cchung100m commented Sep 8, 2019 •
edited
Loading

Following the issue

@kevinthesun
Copy link
Contributor

@yongwww

@kevinthesun kevinthesun added the status: need test case need test cases to cover the change label Sep 9, 2019
yongwww
yongwww approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@yongwww yongwww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinthesun kevinthesun merged commit 5bff6cc into apache:master Sep 10, 2019
@kevinthesun
Copy link
Contributor

Thanks!

wweic pushed a commit to wweic/tvm that referenced this pull request Sep 16, 2019
@cchung100m @wweic
[Relay][Frontend][Keras] Fix ReLU in Keras Converter missed the case (a…
212f5ea 
…pache#3917)

* [Relay][Frontend][Keras] Fix ReLU in Keras Converter missed the case

* [Relay][Frontend][Keras] Add test case for ReLU in Keras Converter missed the case

* [Relay][Frontend][Keras] Add test case for ReLU in Keras Converter missed the case
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 16, 2019
@cchung100m @wweic
[Relay][Frontend][Keras] Fix ReLU in Keras Converter missed the case (a…
b7be323 
…pache#3917)

* [Relay][Frontend][Keras] Fix ReLU in Keras Converter missed the case

* [Relay][Frontend][Keras] Add test case for ReLU in Keras Converter missed the case

* [Relay][Frontend][Keras] Add test case for ReLU in Keras Converter missed the case
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 16, 2019
@cchung100m @wweic
[Relay][Frontend][Keras] Fix ReLU in Keras Converter missed the case (a…
e690303 
…pache#3917)

* [Relay][Frontend][Keras] Fix ReLU in Keras Converter missed the case

* [Relay][Frontend][Keras] Add test case for ReLU in Keras Converter missed the case

* [Relay][Frontend][Keras] Add test case for ReLU in Keras Converter missed the case
@tqchen tqchen mentioned this pull request Nov 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinthesun kevinthesun kevinthesun approved these changes

@yongwww yongwww yongwww approved these changes

@Huyuwei Huyuwei Awaiting requested review from Huyuwei

Assignees
No one assigned
Labels
status: need test case need test cases to cover the change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cchung100m @kevinthesun @yongwww