Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay] Add grads #3857

Merged
merged 2 commits into from
Sep 4, 2019
Merged

[Relay] Add grads #3857

merged 2 commits into from
Sep 4, 2019

Conversation

SWu
Copy link
Contributor

@SWu SWu commented Aug 29, 2019

This implements gradients for a number of common relay ops (#2562). This depends on the updated numerical gradient check from #3856

In addition to unit tests with the numerical gradient check, I've also manually verified these implementations against keras reference gradients.

@SWu
Copy link
Contributor Author

SWu commented Aug 29, 2019

@MarisaKirisame @vinx13 @junrushao1994 please review after #3856

Copy link
Contributor

@MarisaKirisame MarisaKirisame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinx13
Copy link
Member

vinx13 commented Sep 1, 2019

#3856 has been merged, please rebase

@jroesch jroesch merged commit 5ed251a into apache:master Sep 4, 2019
@SWu SWu deleted the add_grads branch September 4, 2019 15:18
MarisaKirisame pushed a commit to MarisaKirisame/tvm that referenced this pull request Sep 7, 2019
* Add gradient implementations

* Add docstrings to fix lint errors
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 16, 2019
* Add gradient implementations

* Add docstrings to fix lint errors
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 16, 2019
* Add gradient implementations

* Add docstrings to fix lint errors
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 16, 2019
* Add gradient implementations

* Add docstrings to fix lint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants