Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay][Frontend][ONNX] Fix code comment for some operators #3830

Merged

Conversation

cchung100m
Copy link
Contributor

Hi @masahi @jroesch @zhiics @vinx13

I Improve the comment for some operators, I would appreciate if you can help to review it, thanks.

@cchung100m cchung100m changed the title Fix code comment of operators [Relay][Frontend][ONNX] Fix code comment for some operators Aug 24, 2019
Copy link
Contributor

@hlu1 hlu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cchung100m
Copy link
Contributor Author

Hi @hlu1
Thanks for the review. :)

@cchung100m
Copy link
Contributor Author

cchung100m commented Aug 24, 2019

Hi @kevinthesun @icemelon9

I would appreciate if you can help to review/merge this PR, thanks.

@hlu1 hlu1 merged commit 70f0a16 into apache:master Aug 24, 2019
@cchung100m cchung100m deleted the fix_code_comment_for_operators_in_frontend_onnx branch August 25, 2019 02:03
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 16, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 16, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants