[Relay] Fix the potential index overflow #3751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchung100m
changed the title
tqchen
approved these changes
Aug 12, 2019
|
Thanks @cchung100m |
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Aug 16, 2019
anijain2305
pushed a commit
to anijain2305/tvm
that referenced
this pull request
Aug 22, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tqchen @YPBlib
Following the issue 3652, I add the additional check to make sure that the cond_shape would only be checked when the index i small than cond_shape and x_shape both in order to avoid a case when cond_shape.size() == 1 but x_shape.size is not.