Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTA] [Chisel] Improved Data Gen, Added ALU Test #3743

Merged
merged 19 commits into from
Aug 13, 2019
Merged

[VTA] [Chisel] Improved Data Gen, Added ALU Test #3743

merged 19 commits into from
Aug 13, 2019

Conversation

BenjaminTu
Copy link
Contributor

Added files for easier data generation
Added ALU Unit test,
all tests passed

Copy link
Member

@vegaluisjose vegaluisjose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ben,

Just did another pass. What is the deal with 3rdparty/dmlc-core in your PR?

@BenjaminTu
Copy link
Contributor Author

hmm I'm not sure about that, I didn't modify anything in it.

@vegaluisjose
Copy link
Member

Could you update your upstream branch and rebase to the branch used in this PR?

Copy link
Member

@vegaluisjose vegaluisjose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now.

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @BenjaminTu! Thank you for your contribution

@tmoreau89 tmoreau89 merged commit 5f9c5e4 into apache:master Aug 13, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Aug 16, 2019
* added alutest

* fix indent

* name change for cycle

* improved data gen and infra

* added alutest

* fix indent

* name change for cycle

* improved data gen and infra

* fix space

* fix indent

* fixes

* aluRef

* fix randomarary

* add

* Revert "add"

This reverts commit 87077da.

* Revert "fix randomarary"

This reverts commit df386c1.

* Revert "aluRef"

This reverts commit 8665f0d.

* should fix dlmc-core
@BenjaminTu BenjaminTu deleted the alu branch August 21, 2019 22:50
anijain2305 pushed a commit to anijain2305/tvm that referenced this pull request Aug 22, 2019
* added alutest

* fix indent

* name change for cycle

* improved data gen and infra

* added alutest

* fix indent

* name change for cycle

* improved data gen and infra

* fix space

* fix indent

* fixes

* aluRef

* fix randomarary

* add

* Revert "add"

This reverts commit 87077da.

* Revert "fix randomarary"

This reverts commit df386c1.

* Revert "aluRef"

This reverts commit 8665f0d.

* should fix dlmc-core
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 6, 2019
* added alutest

* fix indent

* name change for cycle

* improved data gen and infra

* added alutest

* fix indent

* name change for cycle

* improved data gen and infra

* fix space

* fix indent

* fixes

* aluRef

* fix randomarary

* add

* Revert "add"

This reverts commit 87077da.

* Revert "fix randomarary"

This reverts commit df386c1.

* Revert "aluRef"

This reverts commit 8665f0d.

* should fix dlmc-core
tqchen pushed a commit to tqchen/tvm that referenced this pull request Mar 29, 2020
* added alutest

* fix indent

* name change for cycle

* improved data gen and infra

* added alutest

* fix indent

* name change for cycle

* improved data gen and infra

* fix space

* fix indent

* fixes

* aluRef

* fix randomarary

* add

* Revert "add"

This reverts commit 87077da.

* Revert "fix randomarary"

This reverts commit df386c1.

* Revert "aluRef"

This reverts commit 8665f0d.

* should fix dlmc-core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants