-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VTA] [Chisel] Improved Data Gen, Added ALU Test #3743
Conversation
vta/hardware/chisel/src/test/scala/unittest/utils/RandomArray.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Ben,
Just did another pass. What is the deal with 3rdparty/dmlc-core
in your PR?
hmm I'm not sure about that, I didn't modify anything in it. |
Could you update your upstream branch and rebase to the branch used in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @BenjaminTu! Thank you for your contribution
* added alutest * fix indent * name change for cycle * improved data gen and infra * added alutest * fix indent * name change for cycle * improved data gen and infra * fix space * fix indent * fixes * aluRef * fix randomarary * add * Revert "add" This reverts commit 87077da. * Revert "fix randomarary" This reverts commit df386c1. * Revert "aluRef" This reverts commit 8665f0d. * should fix dlmc-core
* added alutest * fix indent * name change for cycle * improved data gen and infra * added alutest * fix indent * name change for cycle * improved data gen and infra * fix space * fix indent * fixes * aluRef * fix randomarary * add * Revert "add" This reverts commit 87077da. * Revert "fix randomarary" This reverts commit df386c1. * Revert "aluRef" This reverts commit 8665f0d. * should fix dlmc-core
* added alutest * fix indent * name change for cycle * improved data gen and infra * added alutest * fix indent * name change for cycle * improved data gen and infra * fix space * fix indent * fixes * aluRef * fix randomarary * add * Revert "add" This reverts commit 87077da. * Revert "fix randomarary" This reverts commit df386c1. * Revert "aluRef" This reverts commit 8665f0d. * should fix dlmc-core
* added alutest * fix indent * name change for cycle * improved data gen and infra * added alutest * fix indent * name change for cycle * improved data gen and infra * fix space * fix indent * fixes * aluRef * fix randomarary * add * Revert "add" This reverts commit 87077da. * Revert "fix randomarary" This reverts commit df386c1. * Revert "aluRef" This reverts commit 8665f0d. * should fix dlmc-core
Added files for easier data generation
Added ALU Unit test,
all tests passed