Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[relay][frontend] clean up tf frontend #3710

Merged
merged 2 commits into from
Aug 6, 2019
Merged

Conversation

zhiics
Copy link
Member

@zhiics zhiics commented Aug 5, 2019

This PR cleans some duplicated code used in the frontends, mainly tf.

cc @srkreddy1238 @icemelon9 @tqchen @jroesch

@zhiics
Copy link
Member Author

zhiics commented Aug 6, 2019

cc @yongwww as well

Copy link
Member

@yongwww yongwww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmoreau89
Copy link
Contributor

seems like a low risk change so I'll go ahead and merge. Thank you @zhiics !

@tmoreau89 tmoreau89 merged commit be8fa6a into apache:master Aug 6, 2019
yy665 added a commit to yy665/tvm that referenced this pull request Aug 6, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Aug 9, 2019
* clean up tf frontend

* fix get_relay_op
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 6, 2019
* clean up tf frontend

* fix get_relay_op
@zhiics zhiics deleted the clean_tf branch October 16, 2019 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants