[TensorFlow] Fix limitation that depth_mult can only be 1 for DepthwiseConv2dNative #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srkreddy1238 please help manage the PR |
|
When this PR merged, I could support tflite frontend. |
|
ping @srkreddy1238 , @kazum can you also please help to take a look? |
kazum
reviewed
Aug 20, 2019
python/tvm/relay/op/nn/_nn.py
Outdated
| @@ -129,19 +129,20 @@ def compute_conv2d(attrs, inputs, out_type, target): | |||
| if dilation_h < 1 or dilation_w < 1: | |||
| raise ValueError("dilation should be positive value") | |||
|
|
|||
| def _get_channels(): | |||
There was a problem hiding this comment.
Is _get_out_depth() better because the returned value makes sense only for depthwise convolution?
kazum
approved these changes
Aug 21, 2019
|
@tqchen Could you help to merge this? Thanks |
|
Thanks @lixiaoquan @kazum ! |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 16, 2019
…seConv2dNative (apache#3676) * [TensorFlow] Fix limitation that depth_mult can only be 1 for DepthwiseConv2dNative * Improve code readability
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 16, 2019
…seConv2dNative (apache#3676) * [TensorFlow] Fix limitation that depth_mult can only be 1 for DepthwiseConv2dNative * Improve code readability
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 16, 2019
…seConv2dNative (apache#3676) * [TensorFlow] Fix limitation that depth_mult can only be 1 for DepthwiseConv2dNative * Improve code readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@srkreddy1238 @yongwww Please review this