[VTA] [Chisel] fix uop load request #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroesch
approved these changes
Jul 28, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Aug 9, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 6, 2019
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently, micro-operations
uopin VTA are 32-bit wide, which is usually lower to the number of bits used by the memory bus. In order to take full advantage of memory bandwidth, micro-ops are loaded in memory burst and written touopmemory. The cost for this approach is aligning/masking the data to be written on SRAMs with the benefit of fully utilizing the bandwidth available.Bug
I recently found a bug when
uopload-requests had an odd offset (SRAM) and even number ofuop. This was causing the integration gemm testtest_benchmark_gemm.pyto fail. With this fix, VTA chisel is now passing the following tests (unit-tests, integration, and tutorial) except fordeploy_resnet_on_vta.pySolution
Incorporate the offset into the calculation of the size of the dma request.