[TOPI][CUDA] Schedule for pool_grad #3622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merrymercy
approved these changes
Jul 25, 2019
topi/python/topi/cuda/pooling.py
Outdated
| out = op | ||
| else: | ||
| out = outs[0].op.output(0) | ||
| s[op].set_scope('local') |
There was a problem hiding this comment.
I think this can be set automatically if it is compute_at a threadIdx
vinx13
force-pushed
the
feature/pool_grad_cuda
branch
2 times, most recently
from
ff29150
to
e5e4040
Compare
|
@vinx13 can you get the pool_grad test from the current mode into numerical checking? In the current mode, we essentially copy and paste the grad function into the test function, and compare the two result. If our orginal concept is wrong, what we test against is likely to also be wrong. I think we should slowly replace basically all gradient test with numerical checking ones, and the more complex the grad is, the more crucial this is for us. |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Aug 9, 2019
* [TOPI][CUDA] Schedule for pool_grad * Relay test * Fix fused op * doc * Remove set scope local
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 6, 2019
* [TOPI][CUDA] Schedule for pool_grad * Relay test * Fix fused op * doc * Remove set scope local
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review @junrushao1994 @MarisaKirisame @merrymercy @masahi