Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS]fix js test load module example #3556

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Conversation

zhreshold
Copy link
Member

Fix the js example which isn't working at all.
JS tvm.ndarray.length is undefined, indexing like A[i] with tvm.ndarray is not defined as well.
So the block

for (var i = 0; i < B.length; ++i) {
    tvm.assert(B[i] == A[i] + 1);
}

was not entered at all.

Also fixing an error when the script is trying to generate js library where options are not properly set.

@zhreshold zhreshold changed the title fix js test load module example [JS]fix js test load module example Jul 17, 2019
@tqchen tqchen merged commit fd6dbd5 into apache:master Jul 17, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Aug 9, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants