Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error #3552

Merged
merged 2 commits into from
Jul 17, 2019
Merged

Fix build error #3552

merged 2 commits into from
Jul 17, 2019

Conversation

yinghai
Copy link
Contributor

@yinghai yinghai commented Jul 16, 2019

Copy link
Contributor

@hlu1 hlu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -23,6 +23,7 @@
* \brief Doc ADT used for pretty printing.
* Based on Section 1 of https://homepages.inf.ed.ac.uk/wadler/papers/prettier/prettier.pdf.
*/
#include <cassert>
#include <memory>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely we don’t need this, but need to change assert to CHECK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

@tqchen tqchen merged commit 48c1ae4 into apache:master Jul 17, 2019
@tqchen
Copy link
Member

tqchen commented Jul 17, 2019

Thanks @hlu1 @yinghai , this PR is now merged

wweic pushed a commit to wweic/tvm that referenced this pull request Aug 9, 2019
* Fix build error

* comments
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 6, 2019
* Fix build error

* comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants