Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTA][Hotfix] Avoiding error when environment variable is not set #3497

Merged
merged 2 commits into from
Jul 5, 2019

Conversation

tmoreau89
Copy link
Contributor

When running hardware tests, we can obtain a test remote via the tracker, or directly. When obtaining from the tracker, one needs to set the TVM_TRACKER_HOST and TVM_TRACKER_PORT environment variables. If unset, the test utility will try to get the hardware remote from the VTA_PYNQ_RPC_HOST and VTA_PYNQ_RPC_PORT environment variables. If either PORT variables are unset, the code below causes an error since we are casting None to int too early.

@eqy
Copy link
Contributor

eqy commented Jul 5, 2019

@tmoreau89 can you retrigger CI so we can merge?

@jroesch jroesch merged commit 1efc84a into apache:master Jul 5, 2019
@tmoreau89 tmoreau89 deleted the hotfix branch July 9, 2019 00:27
wweic pushed a commit to wweic/tvm that referenced this pull request Jul 11, 2019
…ache#3497)

* avoid error when env var is not set

* extra content
wweic pushed a commit to wweic/tvm that referenced this pull request Jul 11, 2019
…ache#3497)

* avoid error when env var is not set

* extra content
wweic pushed a commit to neo-ai/tvm that referenced this pull request Jul 11, 2019
tqchen pushed a commit to tqchen/tvm that referenced this pull request Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants