-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[relay][frontend] Return Module from get_workload #3483
Conversation
Could we add a Python property to |
@jroesch Sure. I will update the rest part of the code for this PR tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. marked remaining mod[mod.entry_point]
@wweic Thanks. I just refactored part of the code last night. Now everything should be updated to |
@jroesch do you have any comments? I am okay with either way. I can refactor to |
Tianqi and I discussed some more, he argues we should just remove and make it so there is no special main function, and we just use main as convention but allow the specification of multiple entry points in the future to passes that do liveness, etc. Sorry for the back and forth, enjoy the holiday! |
@jroesch No worries. I have one question about the updating the function for a globalvar in a module. I might miss something about the multiple entry points. For example, we may create a module ( |
@zhiics I think we should update the "main" just as if it is a normal function |
I think we should just treat all functions uniformly, there are a couple places where we might need to specify an entry point, and we can just default to main. |
* [relay][frontend] Return Module from get_workload * pass entry_func to autotvm * disable tune * add property to module * mod.entry_func to main * .main -> mod["main"] * fix
* [relay][frontend] Return Module from get_workload * pass entry_func to autotvm * disable tune * add property to module * mod.entry_func to main * .main -> mod["main"] * fix
* [relay][frontend] Return Module from get_workload * pass entry_func to autotvm * disable tune * add property to module * mod.entry_func to main * .main -> mod["main"] * fix
* [relay][frontend] Return Module from get_workload * pass entry_func to autotvm * disable tune * add property to module * mod.entry_func to main * .main -> mod["main"] * fix
This PR makes the relay testing frontend returns
Module
as the frontend parsers also returnModule
.cc @tqchen @jroesch @wweic @MarisaKirisame