Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relay] Fix PE #3482

Merged
merged 2 commits into from
Jul 4, 2019
Merged

[Relay] Fix PE #3482

merged 2 commits into from
Jul 4, 2019

Conversation

MarisaKirisame
Copy link
Contributor

@MarisaKirisame MarisaKirisame commented Jul 3, 2019 •
edited
Loading

Fix #3449
previous to this fix PE will erroneously partially evaluate the same global function multiple time.
This fix it by sharing the same map.

@nhynes @vinx13 @icemelon9 can you guys review?

@MarisaKirisame
do
a04af16 
fix some error

fix

remove cout

retrigger build
@MarisaKirisame
fix it!
004caf5
@tqchen
Copy link
Member

tqchen commented Jul 3, 2019

do we have a regression test case for this?

@tqchen tqchen added the status: need test case need test cases to cover the change label Jul 3, 2019
@MarisaKirisame
Copy link
Contributor Author

@tqchen yes! All test in test_pass_pe now loop through the whole module, PEing every one of them!
So we automatically get new test of nat_iter, map, tree_map along side the old one!

@tqchen tqchen merged commit b3f3ab5 into apache:master Jul 4, 2019
@tqchen tqchen added status: accepted and removed status: need test case need test cases to cover the change labels Jul 4, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Jul 11, 2019
@MarisaKirisame
[Relay] Fix PE (apache#3482)
6d50f2b
wweic pushed a commit to wweic/tvm that referenced this pull request Jul 11, 2019
@MarisaKirisame
[Relay] Fix PE (apache#3482)
9e243b1
wweic pushed a commit to neo-ai/tvm that referenced this pull request Jul 11, 2019
@MarisaKirisame @wweic
[Relay] Fix PE (apache#3482)
249d992
@MarisaKirisame MarisaKirisame deleted the fix-pe branch July 13, 2019 20:58
@yzhliu yzhliu mentioned this pull request Nov 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqchen tqchen tqchen approved these changes

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Relay] Make PE mod -> mod
2 participants
@MarisaKirisame @tqchen