Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-allocate buffer for x86 roi_align #3475

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Conversation

kevinthesun
Copy link
Contributor

Copy link
Contributor

@yidawang yidawang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -211,7 +215,21 @@ def roi_align_nchw_cpu(data, rois, pooled_size, spatial_scale, sample_ratio=-1):
"""
if not isinstance(pooled_size, (tuple, list)):
pooled_size = (pooled_size, pooled_size)

# Pre-allocate imtermediate buffer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo intermediate

@yzhliu yzhliu merged commit 287078c into apache:master Jul 3, 2019
@yzhliu
Copy link
Member

yzhliu commented Jul 3, 2019

Thanks @kevinthesun @yidawang

wweic pushed a commit to wweic/tvm that referenced this pull request Jul 11, 2019
* Pre-allocate buffer for x86 roi_align

* Fix typo
wweic pushed a commit to wweic/tvm that referenced this pull request Jul 11, 2019
* Pre-allocate buffer for x86 roi_align

* Fix typo
wweic pushed a commit to neo-ai/tvm that referenced this pull request Jul 11, 2019
* Pre-allocate buffer for x86 roi_align

* Fix typo
@kevinthesun kevinthesun deleted the FixROIAlign branch September 3, 2019 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants