Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Runtime] Android argsort support #3472

Merged
merged 2 commits into from
Jul 2, 2019
Merged

Conversation

jwfromm
Copy link
Contributor

@jwfromm jwfromm commented Jul 1, 2019

Simple change on top of the android contrib fix by @tqchen to enable argsort in the android runtime. See this discussion for more details on this fix.

@jwfromm jwfromm changed the title Android sort [RUNTIME] Android argsort support Jul 1, 2019
Copy link
Member

@yzhliu yzhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also could you remove tq's commit from this pr?

@@ -23,3 +23,7 @@ ifeq ($(USE_VULKAN), 1)
APP_CPPFLAGS += -DTVM_VULKAN_RUNTIME=1
APP_LDFLAGS += -lvulkan
endif

ifeq ($(USE_SORT), 1)
APP_CPPFLAGS += -DUSE_SORT=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use 4-space instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, replaced with spaces.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also split off this commit from Tianqi's changes.

@jwfromm jwfromm changed the title [RUNTIME] Android argsort support [Runtime] Android argsort support Jul 1, 2019
@yzhliu yzhliu merged commit 2646604 into apache:master Jul 2, 2019
@yzhliu
Copy link
Member

yzhliu commented Jul 2, 2019

Thanks @jwfromm !

@jwfromm jwfromm deleted the android_sort branch July 3, 2019 23:58
wweic pushed a commit to wweic/tvm that referenced this pull request Jul 11, 2019
* Add contrib sort functions to android rpc app.

* replaced tab with spaces oops.
wweic pushed a commit to wweic/tvm that referenced this pull request Jul 11, 2019
* Add contrib sort functions to android rpc app.

* replaced tab with spaces oops.
wweic pushed a commit to neo-ai/tvm that referenced this pull request Jul 11, 2019
* Add contrib sort functions to android rpc app.

* replaced tab with spaces oops.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants