-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Runtime] Android argsort support #3472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also could you remove tq's commit from this pr?
@@ -23,3 +23,7 @@ ifeq ($(USE_VULKAN), 1) | |||
APP_CPPFLAGS += -DTVM_VULKAN_RUNTIME=1 | |||
APP_LDFLAGS += -lvulkan | |||
endif | |||
|
|||
ifeq ($(USE_SORT), 1) | |||
APP_CPPFLAGS += -DUSE_SORT=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use 4-space instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, replaced with spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also split off this commit from Tianqi's changes.
Thanks @jwfromm ! |
* Add contrib sort functions to android rpc app. * replaced tab with spaces oops.
* Add contrib sort functions to android rpc app. * replaced tab with spaces oops.
* Add contrib sort functions to android rpc app. * replaced tab with spaces oops.
Simple change on top of the android contrib fix by @tqchen to enable argsort in the android runtime. See this discussion for more details on this fix.