[Relay][VM]Create closure object for GlobalVar #3411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wweic
changed the title
MarisaKirisame
approved these changes
Jun 21, 2019
| self.id = self.mod["id"] | ||
| self.compose = self.mod["compose"] | ||
| self.id = self.mod.get_global_var("id") | ||
| self.compose = self.mod.get_global_var("compose") |
There was a problem hiding this comment.
mod["id"] returns Function. But the function name symbols need to be GlobalVar, you can check other prelude functions. Otherwise it would cause errors like https://discuss.tvm.ai/t/relay-to-a-normal-form-fails-on-a-prelude-function/3031.
zhiics
approved these changes
Jun 21, 2019
jroesch
reviewed
Jun 22, 2019
| auto it = this->context->global_map.find(var); | ||
| CHECK(it != this->context->global_map.end()); | ||
| // Allocate closure with zero free vars | ||
| Emit(Instruction::AllocClosure(it->second, 0, {}, NewRegister())); |
There was a problem hiding this comment.
I think we should merge for now, but eta expand these in the future then optimize/lift.
jroesch
approved these changes
Jun 22, 2019
wweic
added a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
wweic
added a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For function like:
We should create a closure object for
lifted_name12481580008527263117.cc @icemelon9 @jroesch @zhiics @MarisaKirisame @slyubomirsky