Update CMakeLists.txt to be more flexible #3354
Conversation
Update CMakeLists.txt to be more flexible to find the third parties libraries
|
@junrushao1994 could you please take a look on that? |
|
Hey, this change is absolutely correct. Just to confirm, is this used for building conda-forge packages? |
|
Hey @junrushao1994 , yes, it would be good to have it, otherwise, I will have to patch the CMakeLists.txt, usually, in conda-forge we try to avoid third paties packages which are shipped along with the project. As I mentioned before, I already packaged those dependencies which tvm needs. |
CMakeLists.txt
Outdated
| include_directories(${DLPACK_PATH}) | ||
| include_directories(${DMLC_PATH}) | ||
| include_directories(${RANG_PATH}) | ||
| include_directories(${RT_PATH}) |
There was a problem hiding this comment.
Let’s change it to COMPILER_RT_PATH
There was a problem hiding this comment.
Sure, I am going to change it
|
BTW, what’s the status of current tvm/conda directory (https://github.com/dmlc/tvm/tree/master/conda)? Isn’t that suppose to be working properly with conda-forge? |
Not with conda-forge, but it might help, because conda-forge has their own structure to build the package, usually the users just have to write a recipe and our infrastructure should do the rest |
|
Thanks ,@marcelotrevisani @junrushao1994 this PR is now merged |
Update CMakeLists.txt to be more flexible to find the third parties libraries
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.