Add MUL operator to relay tflite frontend #3304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apivovarov
commented
Jun 7, 2019
| @@ -24,7 +24,6 @@ | |||
| import numpy as np | |||
| import tvm | |||
| from tvm import relay | |||
| from tvm.contrib import util | |||
There was a problem hiding this comment.
Import is not used. I deleted it
apivovarov
commented
Jun 7, 2019
| @@ -144,8 +143,6 @@ def compare_tflite_with_tvm(in_data, in_name, input_tensors, | |||
| for i in range(len(tflite_output)): | |||
| tvm.testing.assert_allclose(tflite_output[i], tvm_output[i], atol=1e-5, rtol=1e-5) | |||
|
|
|||
| sess.close() | |||
There was a problem hiding this comment.
line 127 opens new with tf.Session() as sess: context block.
After python finishes with tf.Session block execution it callssess.__exit__() method automatically which calls self.close() to close the session.
We do not need to close sess explicitly.
kevinthesun
approved these changes
Jun 7, 2019
|
@srkreddy1238 @jroesch @FrozenGene Can you have a look? |
FrozenGene
approved these changes
Jun 7, 2019
|
@kevinthesun please manage the PR |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MUL operator is used in TFLite SSD Resnet 50 model (ssd_resnet_50_fpn_coco).
Model graph: ssd_resnet_50_fpn_coco.tflite.pdf
This PR transforms existing
convert_addmethod to generic_convert_elemwisemethod (similar approach is used in tensorflow frontend code)Existing
convert_addand newconvert_mulmethods use_convert_elemwisemethod now.I also created
_test_elemwisemethod based on existing_test_addmethod.Both
_test_addand_test_muluse_test_elemwisemethod now