[Relay][heterogeneous pass] remove on_device op after annotation #3204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imorinaga
reviewed
May 17, 2019
imorinaga
reviewed
May 17, 2019
Co-Authored-By: MORINAGA <[email protected]>
|
Looks good, idea is to only leave the copies in place? |
|
@jroesch Yes. With |
|
@imorinaga could you explicitly approve the changes using the interface? |
imorinaga
approved these changes
May 21, 2019
|
Looks good to me. |
jroesch
approved these changes
May 21, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
…che#3204) * remove on_device op after annotation * Update src/relay/pass/device_annotation.cc Co-Authored-By: MORINAGA <[email protected]>
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
…che#3204) * remove on_device op after annotation * Update src/relay/pass/device_annotation.cc Co-Authored-By: MORINAGA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
on_deviceoperator after rewriting the annotated graph so that users can conveniently use this pass.cc' @kazum @imorinaga @jroesch @yzhliu